Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spawn EINVAL error on Windows #84

Merged
merged 3 commits into from Apr 17, 2024

Conversation

derevnjuk
Copy link
Contributor

fixes #83

index.js Outdated Show resolved Hide resolved
@derevnjuk derevnjuk requested a review from vweevers April 15, 2024 17:36
Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @mafintosh's comment here makes me unsure: #81 (comment)

@vweevers vweevers requested a review from mafintosh April 15, 2024 17:41
@derevnjuk
Copy link
Contributor Author

derevnjuk commented Apr 15, 2024

@vweevers If so, it is better to enforce shell in this particular case like this:

-var child = execspawn(cmd, {
+var child = proc.spawn(cmd, [], {
  cwd: opts.cwd,
  env: opts.env,
  stdio: 'inherit',
-  shell: opts.shell
+  shell: opts.shell || true,
+  windowsHide: true
})

c14ed8b wdyt?

@vweevers vweevers changed the title fix spawn EINVAL error Fix spawn EINVAL error on Windows Apr 17, 2024
@vweevers vweevers merged commit 86b9d7b into prebuild:master Apr 17, 2024
3 checks passed
@vweevers
Copy link
Member

6.0.1

@derevnjuk derevnjuk deleted the fix-#83/spawn-EINVAL-error branch April 18, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error: spawn EINVAL
2 participants