Disable importConditionDefaultExport for now

.changeset/honest-cheetahs-stare.md

@@ -0,0 +1,5 @@
+---
+"@preconstruct/cli": patch
+---
+
+Disable specifying `importConditionDefaultExport` because it doesn't work correctly in `"moduleResoltion": "bundler"`, `@preconstruct/cli@2.6.0` is npm deprecated, `importConditionDefaultExport` will come back in the future.

packages/cli/src/__tests__/dev.ts

@@ -418,7 +418,7 @@ test(".d.ts file with default export", async () => {
   `);
 });
 
-test("with default", async () => {
+test.skip("with default", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "@mjs-proxy/repo",

packages/cli/src/__tests__/validate.ts

@@ -729,7 +729,7 @@ describe("exports field config", () => {
         `[Error: the "preconstruct.exports" field contains an unknown key "something"]`
       );
     });
-    test("invalid importConditionDefaultExport", async () => {
+    test.skip("invalid importConditionDefaultExport", async () => {
       const tmpPath = await exportsFieldConfigTestDir({
         importConditionDefaultExport: "something",
       });
@@ -745,14 +745,14 @@ describe("exports field config", () => {
       { envConditions: [] },
       { envConditions: [], extra: {} },
       { extra: {} },
-      { envConditions: [], importConditionDefaultExport: "namespace" },
-      {
-        envConditions: [],
-        extra: {},
-        importConditionDefaultExport: "namespace",
-      },
-      { extra: {}, importConditionDefaultExport: "namespace" },
-      { importConditionDefaultExport: "namespace" },
+      // { envConditions: [], importConditionDefaultExport: "namespace" },
+      // {
+      //   envConditions: [],
+      //   extra: {},
+      //   importConditionDefaultExport: "namespace",
+      // },
+      // { extra: {}, importConditionDefaultExport: "namespace" },
+      // { importConditionDefaultExport: "namespace" },
       true,
     ];
     for (const config of configsEquivalentToTrue) {
@@ -781,7 +781,7 @@ describe("exports field config", () => {
       });
     }
   });
-  test('{ "importConditionDefaultExport": "default" }', async () => {
+  test.skip('{ "importConditionDefaultExport": "default" }', async () => {
     const tmpPath = await testdir({
       "package.json": JSON.stringify({
         name: "pkg-a",
@@ -877,14 +877,14 @@ describe("project level exports field config", () => {
         importConditionDefaultExport: "something",
       });
       await expect(validate(tmpPath)).rejects.toMatchInlineSnapshot(
-        `[Error: the "preconstruct.exports.importConditionDefaultExport" field must be set to "default" or "namespace" if it is present]`
+        `[Error: the "preconstruct.exports.importConditionDefaultExport" is currently broken and disabled, it will be re-enabled with a different implemtation in a future version]`
       );
     });
   });
   describe("true", () => {
     const configsEquivalentToTrue = [
       {},
-      { importConditionDefaultExport: "namespace" },
+      // { importConditionDefaultExport: "namespace" },
       true,
     ];
     for (const config of configsEquivalentToTrue) {
@@ -894,7 +894,7 @@ describe("project level exports field config", () => {
       });
     }
   });
-  test('{ "importConditionDefaultExport": "default" }', async () => {
+  test.skip('{ "importConditionDefaultExport": "default" }', async () => {
     const tmpPath = await testdir({
       "package.json": JSON.stringify({
         name: "repo",

packages/cli/src/build/__tests__/build.ts

@@ -918,7 +918,7 @@ test("self import", async () => {
   `);
 });
 
-test("correct default export using mjs and dmts proxies", async () => {
+test.skip("correct default export using mjs and dmts proxies", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "@mjs-proxy/repo",
@@ -1135,7 +1135,7 @@ test("correct default export using mjs and dmts proxies", async () => {
   expect(node.stderr.toString("utf8")).toMatchInlineSnapshot(`""`);
 });
 
-test("importing a package via dynamic import from another package provides the right types", async () => {
+test.skip("importing a package via dynamic import from another package provides the right types", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "@mjs-proxy/repo",
@@ -1272,7 +1272,7 @@ test("importing a package via dynamic import from another package provides the r
   `);
 });
 
-test("importing another package via dynamic import and exporting the namespace produces a typescript error because the type cannot be named", async () => {
+test.skip("importing another package via dynamic import and exporting the namespace produces a typescript error because the type cannot be named", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "@mjs-proxy/repo",
@@ -1349,7 +1349,7 @@ test("importing another package via dynamic import and exporting the namespace p
   `);
 });
 
-test("importing another package via dynamic import and exporting something that requires importing a type from the other package works", async () => {
+test.skip("importing another package via dynamic import and exporting something that requires importing a type from the other package works", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "@mjs-proxy/repo",
@@ -1459,7 +1459,7 @@ test("importing another package via dynamic import and exporting something that
   `);
 });
 
-test("no __esModule when reexporting namespace with mjs proxy", async () => {
+test.skip("no __esModule when reexporting namespace with mjs proxy", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "@mjs-proxy-no-__esmodule/repo",
@@ -1582,7 +1582,7 @@ test("no __esModule when reexporting namespace with mjs proxy", async () => {
   expect(node.stderr.toString("utf8")).toMatchInlineSnapshot(`""`);
 });
 
-test("export * from external", async () => {
+test.skip("export * from external", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "repo",
@@ -1746,7 +1746,7 @@ test("export * from external", async () => {
   expect(stderr.toString("utf8")).toMatchInlineSnapshot(`""`);
 });
 
-test("type only export imported in .mts", async () => {
+test.skip("type only export imported in .mts", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "repo",
@@ -1839,7 +1839,7 @@ test("type only export imported in .mts", async () => {
   expect(stderr.toString("utf8")).toMatchInlineSnapshot(`""`);
 });
 
-test("importConditionDefaultExport: default with use client", async () => {
+test.skip("importConditionDefaultExport: default with use client", async () => {
   let dir = await testdir({
     "package.json": JSON.stringify({
       name: "pkg-a",

packages/cli/src/package.ts

@@ -17,6 +17,7 @@ import {
   setFieldInOrder,
   DistFilenameStrategy,
   MinimalEntrypoint,
+  parseImportConditionDefaultExportOption,
 } from "./utils";
 import normalizePath from "normalize-path";
 
@@ -406,14 +407,10 @@ function parseExportsFieldConfig(
         );
       }
     } else if (key === "importConditionDefaultExport") {
-      if (value === "default" || value === "namespace") {
-        parsedConfig.importConditionDefaultExport = value;
-      } else {
-        throw new FatalError(
-          'the "preconstruct.exports.importConditionDefaultExport" field must be set to "default" or "namespace" if it is present',
-          name
-        );
-      }
+      parsedConfig.importConditionDefaultExport = parseImportConditionDefaultExportOption(
+        value,
+        name
+      );
     } else {
       throw new FatalError(
         `the "preconstruct.exports" field contains an unknown key "${key}"`,

packages/cli/src/project.ts

@@ -6,7 +6,7 @@ import { Item } from "./item";
 import { Package } from "./package";
 import { validateIncludedFiles } from "./validate-included-files";
 import { FatalError } from "./errors";
-import { JSONValue, parseimportConditionDefaultExportOption } from "./utils";
+import { JSONValue, parseImportConditionDefaultExportOption } from "./utils";
 
 const allSettled = (promises: Promise<any>[]) =>
   Promise.all(
@@ -162,7 +162,7 @@ export class Project extends Item<{
     }
     for (const [key, val] of Object.entries(exportsFieldConfig)) {
       if (key === "importConditionDefaultExport") {
-        importConditionDefaultExport = parseimportConditionDefaultExportOption(
+        importConditionDefaultExport = parseImportConditionDefaultExportOption(
           val,
           this.name
         );

packages/cli/src/utils.ts

@@ -280,15 +280,19 @@ export type JSONValue =
   | Array<JSONValue>
   | { [key: string]: JSONValue | undefined };
 
-export function parseimportConditionDefaultExportOption(
+export function parseImportConditionDefaultExportOption(
   value: unknown,
   name: string
-) {
-  if (value === "default" || value === "namespace") {
-    return value;
-  }
+): "default" | "namespace" {
   throw new FatalError(
-    'the "preconstruct.exports.importConditionDefaultExport" field must be set to "default" or "namespace" if it is present',
+    `the "preconstruct.exports.importConditionDefaultExport" is currently broken and disabled, it will be re-enabled with a different implemtation in a future version`,
     name
   );
+  // if (value === "default" || value === "namespace") {
+  //   return value;
+  // }
+  // throw new FatalError(
+  //   'the "preconstruct.exports.importConditionDefaultExport" field must be set to "default" or "namespace" if it is present',
+  //   name
+  // );
 }