Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass tsconfig path to typescript parseJsonConfigFileContent #495

Merged
merged 11 commits into from
Sep 29, 2022
Merged

fix: Pass tsconfig path to typescript parseJsonConfigFileContent #495

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
646c9cd
fix: Pass package path to typescript parseJsonConfigFileContent
Sep 23, 2022
ac66691
style: Fix prettier errors
Sep 23, 2022
082d948
chore: Add changeset
Sep 23, 2022
446f3fd
Revert "style: Fix prettier errors"
Sep 26, 2022
5773cef
Revert "fix: Pass package path to typescript parseJsonConfigFileContent"
Sep 26, 2022
9888c97
fix(typescript-declarations): Pass config file directory to paseJsonC…
Sep 26, 2022
59a3771
chore: Update changeset message
Sep 26, 2022
f6163a2
test: Verify typescript packages with root src/ dir can be build
Sep 27, 2022
1fa958c
feat(typescript-declarations): Unset outDir and declarationDir from t…
Sep 28, 2022
1f35a93
Revert "fix(typescript-declarations): Pass config file directory to p…
Sep 28, 2022
629d539
Apply suggestions from code review
emmatown Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-flies-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@preconstruct/cli": patch
---

Pass config file path to typescript so relative paths are applied to correct directory
emmatown marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion packages/cli/src/rollup-plugins/typescript-declarations/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ async function nonMemoizedGetProgram(typescript: TS, configFileName: string) {
let thing = typescript.parseJsonConfigFileContent(
result.config,
typescript.sys,
process.cwd(),
path.dirname(configFileName),
undefined,
configFileName
);
Expand Down