Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typeScriptProxyFileWithImportEqualsRequireAndExportEquals experimental flag #512

Merged
merged 1 commit into from Jan 6, 2023

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jan 6, 2023

This solution to needing to re-run preconstruct dev after adding/removing a default export to an entrypoint didn't work out because export = can't be used with export *.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2023

🦋 Changeset detected

Latest commit: 29bf44e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 90.84% // Head: 90.82% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (29bf44e) compared to base (46be77a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   90.84%   90.82%   -0.02%     
==========================================
  Files          33       33              
  Lines        1496     1494       -2     
  Branches      424      421       -3     
==========================================
- Hits         1359     1357       -2     
  Misses        131      131              
  Partials        6        6              
Impacted Files Coverage Δ
packages/cli/src/project.ts 79.62% <ø> (ø)
packages/cli/src/validate.ts 88.23% <ø> (ø)
packages/cli/src/dev.ts 97.14% <100.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emmatown emmatown merged commit 09784cd into main Jan 6, 2023
@emmatown emmatown deleted the remove-export-equals-experimental-flag branch January 6, 2023 00:46
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant