Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZPOPMIN & ZPOPMAX with "prefix first" option added to the KeyPrefixProcessor #1432

Open
wants to merge 1 commit into
base: v2.x
Choose a base branch
from

Conversation

sngrl
Copy link

@sngrl sngrl commented Feb 9, 2024

No description provided.

Add ZPOPMIN & ZPOPMAX with "prefix first" option
@sngrl sngrl requested a review from tillkruss as a code owner February 9, 2024 22:10
@coveralls
Copy link

Coverage Status

coverage: 80.265% (+0.06%) from 80.208%
when pulling 294de23 on sngrl:patch-1
into d44f073 on predis:v2.x.

@vladvildanov
Copy link
Contributor

@sngrl Would you mind to add a test coverage? Literally, it's just about extending already existing data provider in unit tests

@sngrl2
Copy link

sngrl2 commented Feb 12, 2024

@vladvildanov tests already are presented, my PR just makes this commands to use prefixes

\Predis\Command\Redis\ZPOPMIN_Test
\Predis\Command\Redis\ZPOPMAX_Test

@vladvildanov
Copy link
Contributor

@sngrl2 Ah, my bad! Approved

But you also need to run composer style:fix command to fix codestyle issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants