v3.0.0-alpha #566
Merged
v3.0.0-alpha #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(deps): update hoist-non-react-statics to ^3.1.0 * feat(HOCs): switch firestoreConnect and firebaseConnect to use componentDidMount over componentWillMount
* feat(core): New react context API working with HOCs (`firebaseConnect`, `firestoreConnect` `withFirebase`, and `withFirestore`) - #581 * feat(core): support `react-redux` v6 by removing usage of `context.store` (used to be added by `Provider` from `react-redux`) * feat(core): Added `ReactReduxFirebaseContext` and `ReduxFirestoreContext` (with associated providers `ReactReduxFirebaseProvider` `ReduxFirestoreProvider` respectively) Breaking Change: react 16.4 is now a requirement due to using new context api
* fix(tests): use node 6 as target during tests * feat(core): remove getFirebase * feat(core): add sourcemaps (now that lib/es code is minified)
Codecov Report
@@ Coverage Diff @@
## next #566 +/- ##
===========================================
- Coverage 92.16% 78.25% -13.92%
===========================================
Files 23 26 +3
Lines 2567 915 -1652
Branches 406 166 -240
===========================================
- Hits 2366 716 -1650
+ Misses 201 199 -2 |
Codecov Report
@@ Coverage Diff @@
## next #566 +/- ##
==========================================
- Coverage 92.16% 85.34% -6.83%
==========================================
Files 23 27 +4
Lines 2567 2593 +26
Branches 406 397 -9
==========================================
- Hits 2366 2213 -153
- Misses 201 380 +179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
firestoreConnectandfirebaseConnectto usecomponentDidMountovercomponentWillMount- feat(HOCs): support running in react strict/concurrent mode #564firebaseConnect,firestoreConnectwithFirebase, andwithFirestore) - Support React-Redux v6 #581react-reduxv6 by removing usage ofcontext.store(used to be added byProviderfromreact-redux)ReactReduxFirebaseContextandReduxFirestoreContext(with associated providersReactReduxFirebaseProviderReduxFirestoreProviderrespectively)babel-preset-minify- react-redux-firebase dist output could be reduced further #573hoist-non-react-staticsto^3.1.0babel^7webpack^4(along withwebpack-cli)^16.4for new Context API (matchesreact-redux)NOTE Breaking Changes Including:
getFirebaseandreactReduxFirebaseCheck List
If not relevant to pull request, check off as complete
Relevant Issues