New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download node binary in GH action #22683
Conversation
0012c7c
to
762777d
Compare
this CI run: https://github.com/prestodb/presto/actions/runs/8980256103/job/24663568049?pr=22683 hit the cache. |
8154be5
to
dc910aa
Compare
this CI job: https://github.com/prestodb/presto/actions/runs/8980341932/job/24663806501?pr=22683 verified the ready to uncomment the code and revert the pom.xml change. |
Add a script to download node/yarn binary in GH action with retry feature to prevent the unstable connection when downloading the node/yarn binary in the Maven build. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
dc910aa
to
2af2a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any possibility we could load everything including node from the Maven repository system instead? This separate load mechanism has proved to be a large problem for those of us behind corporate firewalls.
@elharo unfortunately, node/yarn is not in the Maven repo. and I agree with you about the corporate firewall. The same issue also applied to Docker Hub or other services with rate limits based on IP address. As for node and yarn, they shouldn't be blocked by the corporate firewall since most of the developers need them. I believe corporates should have proxy/caching for those tools. The solution here is for GH action and that's why the script is put under the |
Description
Add a script to download node/yarn binary in GH action with retry feature to prevent the unstable connection when downloading the node/yarn binary in the Maven build.
fixed: #22676
Motivation and Context
Use the retry mechanism to avoid the unstable connection when building the presto-main
Impact
In the GH action workflows, run the script with the maven cache population.
Test Plan
Verify the CI runs for this PR
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.