-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also check for Presto Native operator names in QueryStats. #22701
Conversation
presto-main/src/main/java/com/facebook/presto/execution/QueryStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spershin thanks!
presto-main/src/main/java/com/facebook/presto/execution/QueryStats.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/QueryStats.java
Outdated
Show resolved
Hide resolved
dac55d1
to
93da9f5
Compare
26423a9
to
2799969
Compare
Presto Native operator names are different. To properly report 'shuffled' and 'raw input' query stats when running Presto Native, we also check Presto Native operator names.
2799969
to
e62a59b
Compare
Wondering if we can just add a boolean flag on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spershin Thanks for the update!
So, does this mean that we want two bool flags? |
@spershin yes, that works. |
I might need some pointer to code site(s) where we populate the OperatorStats. |
NVM, found it. |
I don't think it is a good idea to add two struct fields just for that. |
Presto Native operator names are different.
Description
To properly report 'shuffled' and 'raw input' query stats when running Presto Native, we also check Presto Native operator names.