Allow content-length of 0 (request#920)

fix check for if length is set in order to allow passing a 0-length buffer as body
pretorh · Dec 10, 2018 · 6dcdce7 · 6dcdce7
1 parent b3926a3
commit 6dcdce7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/request.js b/request.js
@@ -431,7 +431,7 @@ Request.prototype.init = function (options) {
         length = self.body.length
       }
 
-      if (length) {
+      if (length !== undefined) {
         self.setHeader('content-length', length)
       } else {
         self.emit('error', new Error('Argument error, options.body.'))

diff --git a/tests/test-headers.js b/tests/test-headers.js
@@ -101,6 +101,20 @@ function addTests () {
     function (t, req, res) {
       t.equal(req.headers.cookie, undefined)
     })
+
+  runTest(
+    '#920: allow content-length of 0',
+    'headers.json',
+    {
+      json: false,
+      method: 'POST',
+      headers: { 'content-type': 'text/plain; charset=UTF-8' },
+      body: Buffer.alloc(0)
+    },
+    function (t, req, res) {
+      t.equal(req.headers['content-length'], '0')
+    }
+  )
 }
 
 tape('setup', function (t) {