This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
fix: Use fork of prettier-eslint with cwd fix #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisl9029
force-pushed
the
use-fork-of-prettier-eslint-with-cwd-fix
branch
from
110369f
to
5f81493
Compare
Using a temporary fork for prettier-eslint due to maintainer having been unresponsive. Feels warranted as this is a showstopping bug affecting many users. fix prettier#505
lewisl9029
force-pushed
the
use-fork-of-prettier-eslint-with-cwd-fix
branch
from
5f81493
to
2e0b684
Compare
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 1 1
Lines 61 61
Branches 7 7
=====================================
Misses 54 54
Partials 7 7Continue to review full report at Codecov.
|
lewisl9029
added a commit
to lewisl9029/prettier-atom
that referenced
this pull request
Nov 4, 2019
…lint' This is an alternative implemnetation of prettier#564, which used yarn alias to avoid making code changes. Unfortunately apm is tightly coupled to npm, which doesn't support the alias feature. fix prettier#565
lewisl9029
added a commit
to lewisl9029/prettier-atom
that referenced
this pull request
Nov 4, 2019
This is an alternative implementation of prettier#564, which used yarn alias to avoid making code changes. Unfortunately apm is tightly coupled to npm, which doesn't support the alias feature. fix prettier#565
lewisl9029
added a commit
to lewisl9029/prettier-atom
that referenced
this pull request
Nov 5, 2019
This is an alternative implementation of prettier#564, which used yarn alias to avoid making code changes. Unfortunately apm is tightly coupled to npm, which doesn't support the alias feature. fix prettier#565
lewisl9029
added a commit
to lewisl9029/prettier-atom
that referenced
this pull request
Nov 5, 2019
This is an alternative implementation of prettier#564, which used yarn alias to avoid making code changes. Unfortunately apm is tightly coupled to npm, which doesn't support the alias feature. fix prettier#565
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a temporary fork for prettier-eslint due to maintainer having been unresponsive. Feels
warranted as this is a showstopping bug affecting many users.
Fork uses the changes in this PR: prettier/prettier-eslint#242
Implemented using yarn's alias feature: https://yarnpkg.com/lang/en/docs/cli/add/#toc-yarn-add-alias
fix #505