Skip to content

Commit

Permalink
fix: Don't specify any jsxBracketSameLine parameter if none is specif…
Browse files Browse the repository at this point in the history
…ied (#430)

By removing the default value for jsx-bracket-same-line (which is just
  `undefined` anyway), no option value at all for jsxBracketSameLine will
  be generated if none is specified. Then if a recent version of prettier
  is in use for which that option is deprecated, it won't complain.

  Resolves #428.
  • Loading branch information
gwhitney committed May 11, 2022
1 parent f9debed commit 04a8e04
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Expand Up @@ -232,6 +232,15 @@
"maintenance"
]
},
{
"login": "gwhitney",
"name": "Glen Whitney",
"avatar_url": "https://avatars.githubusercontent.com/u/3825429?v=4",
"profile": "https://github.com/gwhitney",
"contributions": [
"maintenance"
]
},
{
"login": "idahogurl",
"name": "Rebecca Vest",
Expand Down
1 change: 1 addition & 0 deletions README.md
Expand Up @@ -279,6 +279,7 @@ Thanks goes to these people ([emoji key][emojis]):
<tr>
<td align="center"><a href="https://github.com/sscaff1"><img src="https://avatars1.githubusercontent.com/u/1554424?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Steven Scaffidi</b></sub></a><br /><a href="https://github.com/prettier/prettier-eslint-cli/commits?author=sscaff1" title="Documentation">📖</a></td>
<td align="center"><a href="http://danielwilhelmsen.com"><img src="https://avatars3.githubusercontent.com/u/1758049?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Daniel Wilhelmsen</b></sub></a><br /><a href="https://github.com/prettier/prettier-eslint-cli/commits?author=dpwilhelmsen" title="Code">💻</a> <a href="#maintenance-dpwilhelmsen" title="Maintenance">🚧</a></td>
<td align="center"><a href="https://github.com/gwhitney"><img src="https://avatars.githubusercontent.com/u/3825429?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Glen Whitney</b></sub></a><br /><a href="#maintenance-gwhitney" title="Maintenance">🚧</a></td>
<td align="center"><a href="https://campcode.dev/"><img src="https://avatars.githubusercontent.com/u/10620169?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Rebecca Vest</b></sub></a><br /><a href="https://github.com/prettier/prettier-eslint-cli/commits?author=idahogurl" title="Code">💻</a></td>
</tr>
</table>
Expand Down

0 comments on commit 04a8e04

Please sign in to comment.