Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filepath to prettierOptions #967

Closed
wants to merge 1 commit into from

Conversation

shiatsumat
Copy link

@shiatsumat shiatsumat commented Sep 25, 2019

Add filepath to prettierOptions in PrettierEditProvider.ts.
This resolves the issue of #955, since prettier judges whether a file is *.tsx based on options.filepath (see https://github.com/prettier/prettier/blob/bb037eb218cbcf914575fe95d9f43e87ffab69a9/src/language-js/printer-estree.js).

  • Run tests
  • Update the CHANGELOG.md with a summary of your changes

Add `filepath` to `prettierOptions` in `PrettierEditProvider.ts`.
This resolves the issue of prettier#955, since prettier judges whether a file is `*.tsx` based on `options.filepath` (see https://github.com/prettier/prettier/blob/bb037eb218cbcf914575fe95d9f43e87ffab69a9/src/language-js/printer-estree.js).
@ntotten
Copy link
Member

ntotten commented Oct 11, 2019

Manually added through 035b4c4. Thanks!

@ntotten ntotten closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants