Add new tuple and record tests. Fix old test

prettier · Jul 1, 2020 · 1026ac0 · 1026ac0
1 parent be46ef0
commit 1026ac0
Show file tree

Hide file tree

Showing 7 changed files with 101 additions and 7 deletions.
diff --git a/src/language-js/parser-babel.js b/src/language-js/parser-babel.js
@@ -82,7 +82,18 @@ function createParse(parseMethod, ...pluginCombinations) {
           babelOptions({ sourceType, extraPlugins })
         )
       );
-    } catch (error) {
+    } catch (_error) {
+      // babel@7.10.4 throws `undefined`, when parsing
+      // ```js
+      // alert(
+      // <!-- comment
+      // 'hello world'
+      // )
+      // ```
+      // #8688
+
+      const error = _error || { message: "Unknown error" };
+
       throw createError(
         // babel error prints (l:c) with cols that are zero indexed
         // so we need our custom error

diff --git a/tests/js/record/__snapshots__/jsfmt.spec.js.snap b/tests/js/record/__snapshots__/jsfmt.spec.js.snap
@@ -60,6 +60,36 @@ assert(rest.c === 3);
 ================================================================================
 `;
 
+exports[`invalid-record-method.js format 1`] = `
+====================================options=====================================
+parsers: ["babel"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+// Invalid, https://github.com/babel/babel/pull/11652/
+
+#{
+  a() {},
+  async b() {},
+  get c() {},
+  set d(_) {},
+  *e() {}
+}
+
+=====================================output=====================================
+// Invalid, https://github.com/babel/babel/pull/11652/
+
+#{
+  a() {},
+  async b() {},
+  get c() {},
+  set d(_) {},
+  *e() {},
+};
+
+================================================================================
+`;
+
 exports[`record.js format 1`] = `
 ====================================options=====================================
 parsers: ["babel"]

diff --git a/tests/js/record/invalid-record-method.js b/tests/js/record/invalid-record-method.js
@@ -0,0 +1,9 @@
+// Invalid, https://github.com/babel/babel/pull/11652/
+
+#{
+  a() {},
+  async b() {},
+  get c() {},
+  set d(_) {},
+  *e() {}
+}
diff --git a/tests/js/tuple/__snapshots__/jsfmt.spec.js.snap b/tests/js/tuple/__snapshots__/jsfmt.spec.js.snap
@@ -30,6 +30,32 @@ assert(rest[1] === 3);
 ================================================================================
 `;
 
+exports[`invalid-tuple-holes.js format 1`] = `
+====================================options=====================================
+parsers: ["babel"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+#{
+  a() {},
+  async b() {},
+  get c() {},
+  set d(_) {},
+  *e() {}
+}
+
+=====================================output=====================================
+#{
+  a() {},
+  async b() {},
+  get c() {},
+  set d(_) {},
+  *e() {},
+};
+
+================================================================================
+`;
+
 exports[`syntax.js format 1`] = `
 ====================================options=====================================
 parsers: ["babel"]
@@ -93,3 +119,17 @@ assert(tuple5 === #[2, 2, 3, 4]);
 
 ================================================================================
 `;
+
+exports[`tuple-trailing-comma.js format 1`] = `
+====================================options=====================================
+parsers: ["babel"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+#[1,]
+
+=====================================output=====================================
+#[1];
+
+================================================================================
+`;
diff --git a/tests/js/tuple/invalid-tuple-holes.js b/tests/js/tuple/invalid-tuple-holes.js
@@ -0,0 +1,7 @@
+#{
+  a() {},
+  async b() {},
+  get c() {},
+  set d(_) {},
+  *e() {}
+}
diff --git a/tests/js/tuple/tuple-trailing-comma.js b/tests/js/tuple/tuple-trailing-comma.js
@@ -0,0 +1 @@
+#[1,]
diff --git a/tests/misc/errors/js/__snapshots__/jsfmt.spec.js.snap b/tests/misc/errors/js/__snapshots__/jsfmt.spec.js.snap
@@ -1,14 +1,10 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`html-like-comments.js error test 1`] = `
-"Unexpected token (3:1)
+"Unknown error (0:0)
   1 | // Only support HTML-like comment in HTML
   2 | alert(
-> 3 | <!-- comment
-    | ^
-  4 | 'hello world'
-  5 | )
-  6 | "
+  3 | <!-- comment"
 `;
 
 exports[`module-attributes.js error test 1`] = `