fix(javascript): correctly handle comments in empty arrow function ex…

…pressions (#6087)
prettier · Apr 30, 2019 · 157b020 · 157b020
1 parent c085aeb
commit 157b020
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 0 deletions.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -60,3 +60,23 @@ Examples:
   test(/** @type {!Array} */ (arrOrString).length);
   test(/** @type {!Array} */ (arrOrString).length + 1);
   ```
+
+- JavaScript: respect parenthesis around optional chaining before await ([#6087] by [@evilebottnawi])
+
+  <!-- prettier-ignore -->
+  ```js
+  // Input
+  async function myFunction() {
+    var x = (await foo.bar.blah)?.hi;
+  }
+
+  // Output (Prettier stable)
+  async function myFunction() {
+    var x = await foo.bar.blah?.hi;
+  }
+
+  // Output (Prettier master)
+  async function myFunction() {
+    var x = (await foo.bar.blah)?.hi;
+  }
+  ```
diff --git a/src/language-js/needs-parens.js b/src/language-js/needs-parens.js
@@ -455,6 +455,7 @@ function needsParens(path, options) {
         case "TSAsExpression":
         case "TSNonNullExpression":
         case "BindExpression":
+        case "OptionalMemberExpression":
           return true;
 
         case "MemberExpression":

diff --git a/tests/optional_chaining/__snapshots__/jsfmt.spec.js.snap b/tests/optional_chaining/__snapshots__/jsfmt.spec.js.snap
@@ -33,6 +33,10 @@ a?.b[3].c?.(x).d.e?.f[3].g?.(y).h;
 (list || list2)?.length;
 (list || list2)?.[(list || list2)];
 
+async function HelloWorld() {
+  var x = (await foo.bar.blah)?.hi;
+}
+
 =====================================output=====================================
 var street = user.address?.street;
 var fooValue = myForm.querySelector("input[name=foo]")?.value;
@@ -61,5 +65,9 @@ a?.b?.c.d?.e;
 (list || list2)?.length;
 (list || list2)?.[list || list2];
 
+async function HelloWorld() {
+  var x = (await foo.bar.blah)?.hi;
+}
+
 ================================================================================
 `;
diff --git a/tests/optional_chaining/chaining.js b/tests/optional_chaining/chaining.js
@@ -24,3 +24,7 @@ a?.b[3].c?.(x).d.e?.f[3].g?.(y).h;
 
 (list || list2)?.length;
 (list || list2)?.[(list || list2)];
+
+async function HelloWorld() {
+  var x = (await foo.bar.blah)?.hi;
+}