fix(angular): add missing parens for pipe in ternary (#5397)

prettier · Nov 9, 2018 · 423ddf9 · 423ddf9
1 parent 9acb029
commit 423ddf9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/language-js/needs-parens.js b/src/language-js/needs-parens.js
@@ -513,6 +513,7 @@ function needsParens(path, options) {
         case "SpreadProperty":
         case "BinaryExpression":
         case "LogicalExpression":
+        case "NGPipeExpression":
         case "ExportDefaultDeclaration":
         case "AwaitExpression":
         case "JSXSpreadAttribute":

diff --git a/tests/angular_interpolation/__snapshots__/jsfmt.spec.js.snap b/tests/angular_interpolation/__snapshots__/jsfmt.spec.js.snap
@@ -36,7 +36,8 @@ exports[`pipe-expression.ng - __ng_interpolation-verify 1`] = `
         keyA: reallySuperLongValue,
         keyB: shortValue | pipeB | pipeC: valueToPipeC
       }
-      | aaa
+      | aaa,
+   (hideLinqPanel ? "ReportSelection.HideShowLabel_Show.String" : "ReportSelection.HideShowLabel_Hide.String") | localize:(localizationSection) 
 ]
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 [
@@ -63,6 +64,10 @@ exports[`pipe-expression.ng - __ng_interpolation-verify 1`] = `
           keyA: reallySuperLongValue,
           keyB: shortValue | pipeB | pipeC: valueToPipeC
         }
-    | aaa
+    | aaa,
+  (hideLinqPanel
+    ? "ReportSelection.HideShowLabel_Show.String"
+    : "ReportSelection.HideShowLabel_Hide.String")
+    | localize: localizationSection
 ]
 `;
diff --git a/tests/angular_interpolation/pipe-expression.ng b/tests/angular_interpolation/pipe-expression.ng
@@ -20,5 +20,6 @@
         keyA: reallySuperLongValue,
         keyB: shortValue | pipeB | pipeC: valueToPipeC
       }
-      | aaa
+      | aaa,
+   (hideLinqPanel ? "ReportSelection.HideShowLabel_Show.String" : "ReportSelection.HideShowLabel_Hide.String") | localize:(localizationSection) 
 ]