fix(mdx): treat jsx codeblock same as in markdown (#5391)

prettier · Nov 9, 2018 · 469a831 · 469a831
1 parent 7f472d7
commit 469a831
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 1 deletion.
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js
@@ -6269,7 +6269,7 @@ function isUnitTestSetUp(n) {
 }
 
 function isTheOnlyJSXElementInMarkdown(options, path) {
-  if (options.parentParser !== "markdown") {
+  if (options.parentParser !== "markdown" && options.parentParser !== "mdx") {
     return false;
   }
 

diff --git a/tests/mdx/__snapshots__/jsfmt.spec.js.snap b/tests/mdx/__snapshots__/jsfmt.spec.js.snap
@@ -198,6 +198,48 @@ exports[`jsx.mdx - mdx-verify 2`] = `
 
 `;
 
+exports[`jsx-codeblock.mdx - mdx-verify 1`] = `
+\`\`\`jsx
+<div>foo</div>
+\`\`\`
+
+\`\`\`jsx
+const a = 1;
+<div>foo</div>;
+\`\`\`
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+\`\`\`jsx
+<div>foo</div>
+\`\`\`
+
+\`\`\`jsx
+const a = 1;
+<div>foo</div>;
+\`\`\`
+
+`;
+
+exports[`jsx-codeblock.mdx - mdx-verify 2`] = `
+\`\`\`jsx
+<div>foo</div>
+\`\`\`
+
+\`\`\`jsx
+const a = 1;
+<div>foo</div>;
+\`\`\`
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+\`\`\`jsx
+<div>foo</div>
+\`\`\`
+
+\`\`\`jsx
+const a = 1
+;<div>foo</div>
+\`\`\`
+
+`;
+
 exports[`mixed.mdx - mdx-verify 1`] = `
 import     {     Baz } from     './Fixture'
 import { Buz  }   from './Fixture'

diff --git a/tests/mdx/jsx-codeblock.mdx b/tests/mdx/jsx-codeblock.mdx
@@ -0,0 +1,8 @@
+```jsx
+<div>foo</div>
+```
+
+```jsx
+const a = 1;
+<div>foo</div>;
+```