WIP

prettier · Feb 21, 2023 · 475621c · 475621c
1 parent 2a5b391
commit 475621c
Show file tree

Hide file tree

Showing 3 changed files with 200 additions and 0 deletions.
diff --git a/src/language-js/needs-parens.js b/src/language-js/needs-parens.js
@@ -783,6 +783,15 @@ function needsParens(path, options) {
     case "MemberExpression":
     case "TaggedTemplateExpression":
     case "TSNonNullExpression":
+      if (
+        name === "expression" &&
+        parent.type === "Decorator" &&
+        isMemberExpression(node) &&
+        node.computed
+      ) {
+        return true;
+      }
+
       if (
         name === "callee" &&
         (parent.type === "BindExpression" || parent.type === "NewExpression")

diff --git a/tests/format/js/decorators/__snapshots__/jsfmt.spec.js.snap b/tests/format/js/decorators/__snapshots__/jsfmt.spec.js.snap
@@ -162,6 +162,146 @@ export class Bar {}
 ================================================================================
 `;
 
+exports[`member-expression.js [acorn] format 1`] = `
+"Unexpected character '@' (3:5)
+  1 | [
+  2 |   class {
+> 3 |     @(decorators[0])
+    |     ^
+  4 |     method() {}
+  5 |   },
+  6 |"
+`;
+
+exports[`member-expression.js [espree] format 1`] = `
+"Unexpected character '@' (3:5)
+  1 | [
+  2 |   class {
+> 3 |     @(decorators[0])
+    |     ^
+  4 |     method() {}
+  5 |   },
+  6 |"
+`;
+
+exports[`member-expression.js format 1`] = `
+====================================options=====================================
+parsers: ["babel"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+[
+  class {
+    @(decorators[0])
+    method() {}
+  },
+
+  class {
+    @(decorators?.[0])
+    method() {}
+  },
+
+  class {
+    @(decorators.at(0))
+    method() {}
+  },
+
+  class {
+    @(decorators?.at(0))
+    method() {}
+  },
+
+  class {
+    @(decorators.first)
+    method() {}
+  },
+
+  class {
+    @(decorators?.first)
+    method() {}
+  },
+
+  class {
+    @(decorators[first])
+    method() {}
+  },
+
+  class {
+    @(decorators["first"])
+    method() {}
+  },
+
+  @(decorators[first])
+  class {
+    method() {}
+  },
+
+  @(decorators[0])
+  class {
+    method() {}
+  },
+]
+
+=====================================output=====================================
+[
+  class {
+    @decorators[0]
+    method() {}
+  },
+
+  class {
+    @(decorators?.[0])
+    method() {}
+  },
+
+  class {
+    @decorators.at(0)
+    method() {}
+  },
+
+  class {
+    @(decorators?.at(0))
+    method() {}
+  },
+
+  class {
+    @decorators.first
+    method() {}
+  },
+
+  class {
+    @(decorators?.first)
+    method() {}
+  },
+
+  class {
+    @decorators[first]
+    method() {}
+  },
+
+  class {
+    @decorators["first"]
+    method() {}
+  },
+
+  (
+    @decorators[first]
+    class {
+      method() {}
+    }
+  ),
+
+  (
+    @decorators[0]
+    class {
+      method() {}
+    }
+  ),
+];
+
+================================================================================
+`;
+
 exports[`methods.js [acorn] format 1`] = `
 "Unexpected character '@' (3:3)
   1 |

diff --git a/tests/format/js/decorators/member-expression.js b/tests/format/js/decorators/member-expression.js
@@ -0,0 +1,51 @@
+[
+  class {
+    @(decorators[0])
+    method() {}
+  },
+
+  class {
+    @(decorators?.[0])
+    method() {}
+  },
+
+  class {
+    @(decorators.at(0))
+    method() {}
+  },
+
+  class {
+    @(decorators?.at(0))
+    method() {}
+  },
+
+  class {
+    @(decorators.first)
+    method() {}
+  },
+
+  class {
+    @(decorators?.first)
+    method() {}
+  },
+
+  class {
+    @(decorators[first])
+    method() {}
+  },
+
+  class {
+    @(decorators["first"])
+    method() {}
+  },
+
+  @(decorators[first])
+  class {
+    method() {}
+  },
+
+  @(decorators[0])
+  class {
+    method() {}
+  },
+]