fix(typescript): do not add invalid semi for construct in interface w…

…ith prettier-ignore (#5469)
prettier · Nov 14, 2018 · 5c479cc · 5c479cc
1 parent c4b54e1
commit 5c479cc
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js
@@ -1338,7 +1338,8 @@ function printPathNoParens(path, options, print, args) {
           separatorParts = [separator, line];
           if (
             (prop.node.type === "TSPropertySignature" ||
-              prop.node.type === "TSMethodSignature") &&
+              prop.node.type === "TSMethodSignature" ||
+              prop.node.type === "TSConstructSignature") &&
             hasNodeIgnoreComment(prop.node)
           ) {
             separatorParts.shift();

diff --git a/tests/typescript_interface/__snapshots__/jsfmt.spec.js.snap b/tests/typescript_interface/__snapshots__/jsfmt.spec.js.snap
@@ -67,6 +67,12 @@ interface foo extends bar {
   g(): void;
   h(): void;
 }
+
+interface T<T> {
+  // prettier-ignore
+  new<T>(): T<T>;
+  new<T>(): T<T>;
+}
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 interface Interface {
   // prettier-ignore
@@ -91,6 +97,12 @@ interface foo extends bar {
   h(): void;
 }
 
+interface T<T> {
+  // prettier-ignore
+  new<T>(): T<T>;
+  new <T>(): T<T>;
+}
+
 `;
 
 exports[`ignore.js - typescript-verify 2`] = `
@@ -116,6 +128,12 @@ interface foo extends bar {
   g(): void;
   h(): void;
 }
+
+interface T<T> {
+  // prettier-ignore
+  new<T>(): T<T>;
+  new<T>(): T<T>;
+}
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 interface Interface {
   // prettier-ignore
@@ -140,6 +158,12 @@ interface foo extends bar {
   h(): void
 }
 
+interface T<T> {
+  // prettier-ignore
+  new<T>(): T<T>;
+  new <T>(): T<T>
+}
+
 `;
 
 exports[`long-extends.ts - typescript-verify 1`] = `

diff --git a/tests/typescript_interface/ignore.js b/tests/typescript_interface/ignore.js
@@ -20,3 +20,9 @@ interface foo extends bar {
   g(): void;
   h(): void;
 }
+
+interface T<T> {
+  // prettier-ignore
+  new<T>(): T<T>;
+  new<T>(): T<T>;
+}