Fix ignored element print (#7867)

* Fix ignored element print * Add changelog
prettier · Mar 25, 2020 · 77e3fc0 · 77e3fc0
1 parent 2fc35d2
commit 77e3fc0
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 9 deletions.
diff --git a/changelog_unreleased/html/pr-7867.md b/changelog_unreleased/html/pr-7867.md
@@ -0,0 +1,23 @@
+#### Fix ignored empty inline element print ([#7867](https://github.com/prettier/prettier/pull/7867) by [@fisker](https://github.com/fisker))
+
+<!-- prettier-ignore -->
+```html
+<!--Input-->
+<!--prettier-ignore--><span></span>
+<!--prettier-ignore--><span>_</span>
+
+<!--Prettier stable-->
+<!--prettier-ignore--><span
+></span>
+<!--prettier-ignore--><span>_</span>
+
+<!--Prettier stable (Second format)-->
+<!--prettier-ignore--><span
+
+></span>
+<!--prettier-ignore--><span>_</span>
+
+<!--Prettier master-->
+<!--prettier-ignore--><span></span>
+<!--prettier-ignore--><span>_</span>
+```
diff --git a/src/language-html/printer-html.js b/src/language-html/printer-html.js
@@ -554,12 +554,13 @@ function printChildren(path, options, print) {
         ? hardline
         : softline
       : (needsToBorrowNextOpeningTagStartMarker(prevNode) &&
-          /**
-           *     123<a
-           *          ~
-           *       ><b>
-           */
-          (nextNode.firstChild ||
+          (hasPrettierIgnore(nextNode) ||
+            /**
+             *     123<a
+             *          ~
+             *       ><b>
+             */
+            nextNode.firstChild ||
             /**
              *     123<!--
              *            ~

diff --git a/tests/html_prettier_ignore/__snapshots__/jsfmt.spec.js.snap b/tests/html_prettier_ignore/__snapshots__/jsfmt.spec.js.snap
@@ -14,8 +14,7 @@ printWidth: 80
 123<!--prettier-ignore-->456
 
 <span></span
-><!--prettier-ignore--><span
-></span>
+><!--prettier-ignore--><span></span>
 
 ================================================================================
 `;

diff --git a/tests_config/run_spec.js b/tests_config/run_spec.js
@@ -34,7 +34,6 @@ const unstableTests = new Map(
       "html_angular/attributes.component.html",
       (options) => options.printWidth === 1,
     ],
-    "html_prettier_ignore/cases.html",
     "js_empty/semicolon.js",
     "jsx_ignore/jsx_ignore.js",
     "markdown_footnoteDefinition/multiline.md",