fix(glimmer): preserve empty text attributes (#4897)

prettier · Aug 1, 2018 · 783923a · 783923a
1 parent 1915cc3
commit 783923a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/language-handlebars/printer-glimmer.js b/src/language-handlebars/printer-glimmer.js
@@ -174,7 +174,7 @@ function print(path, options, print) {
     }
     case "AttrNode": {
       const isText = n.value.type === "TextNode";
-      if (isText && n.value.chars === "") {
+      if (isText && n.value.loc.start.column === n.value.loc.end.column) {
         return concat([n.name]);
       }
       const quote = isText ? '"' : "";

diff --git a/tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap b/tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap
@@ -151,6 +151,8 @@ exports[`component.hbs - glimmer-verify 1`] = `
 
 <button disabled=disabled class="disabled"></button>
 
+<img alt="" />
+
 <div ...attributes>Hello</div>
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 <UserGreeting @name="Ricardo" @greeting="Olá" />
@@ -170,6 +172,7 @@ exports[`component.hbs - glimmer-verify 1`] = `
 </button>
 <button disabled class="disabled"></button>
 <button disabled="disabled" class="disabled"></button>
+<img alt="" />
 <div ...attributes>
   Hello
 </div>

diff --git a/tests/html_glimmer/component.hbs b/tests/html_glimmer/component.hbs
@@ -14,4 +14,6 @@
 
 <button disabled=disabled class="disabled"></button>
 
+<img alt="" />
+
 <div ...attributes>Hello</div>