Fix format on html with frontMatter

prettier · Aug 25, 2020 · 8065155 · 8065155
1 parent 7e5f6b9
commit 8065155
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 0 deletions.
diff --git a/changelog_unreleased/html/pr-9043.md b/changelog_unreleased/html/pr-9043.md
@@ -0,0 +1,23 @@
+#### Fix format on html with frontMatter ([#9043](https://github.com/prettier/prettier/pull/9043) by [@fisker](https://github.com/fisker))
+
+<!-- prettier-ignore -->
+```html
+<!-- Input -->
+---
+layout: foo
+---
+
+Test <a
+href="https://prettier.io">abc</a>.
+
+<!-- Prettier stable -->
+TypeError: Cannot read property 'end' of undefined
+  ...
+
+<!-- Prettier master -->
+---
+layout: foo
+---
+
+Test <a href="https://prettier.io">abc</a>.
+```
diff --git a/src/language-html/parser-html.js b/src/language-html/parser-html.js
@@ -280,6 +280,10 @@ function _parse(text, options, parserOptions, shouldParseFrontMatter = true) {
   };
 
   if (frontMatter) {
+    frontMatter.sourceSpan = {
+      start: { offset: 0 },
+      end: { offset: frontMatter.raw.length },
+    };
     rawAst.children.unshift(frontMatter);
   }
 

diff --git a/tests/html/front-matter/__snapshots__/jsfmt.spec.js.snap b/tests/html/front-matter/__snapshots__/jsfmt.spec.js.snap
@@ -28,3 +28,48 @@ slug: home
 
 ================================================================================
 `;
+
+exports[`issue-9042.html format 1`] = `
+====================================options=====================================
+parsers: ["html"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+---
+layout: foo
+---
+
+Test <a
+href="https://prettier.io">abc</a>.
+
+=====================================output=====================================
+---
+layout: foo
+---
+
+Test <a href="https://prettier.io">abc</a>.
+
+================================================================================
+`;
+
+exports[`issue-9042-no-empty-line.html format 1`] = `
+====================================options=====================================
+parsers: ["html"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+---
+layout: foo
+---
+Test <a
+href="https://prettier.io">abc</a>.
+
+=====================================output=====================================
+---
+layout: foo
+---
+
+Test <a href="https://prettier.io">abc</a>.
+
+================================================================================
+`;
diff --git a/tests/html/front-matter/issue-9042-no-empty-line.html b/tests/html/front-matter/issue-9042-no-empty-line.html
@@ -0,0 +1,5 @@
+---
+layout: foo
+---
+Test <a
+href="https://prettier.io">abc</a>.
diff --git a/tests/html/front-matter/issue-9042.html b/tests/html/front-matter/issue-9042.html
@@ -0,0 +1,6 @@
+---
+layout: foo
+---
+
+Test <a
+href="https://prettier.io">abc</a>.