fix(typescript): preserve type parameters of import-types (#4656) (#4662

)
prettier · Jun 25, 2018 · b7eb9af · b7eb9af
1 parent 5db4cc2
commit b7eb9af
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js
@@ -2937,7 +2937,8 @@ function printPathNoParens(path, options, print, args) {
         "import(",
         path.call(print, "argument"),
         ")",
-        !n.qualifier ? "" : concat([".", path.call(print, "qualifier")])
+        !n.qualifier ? "" : concat([".", path.call(print, "qualifier")]),
+        printTypeParameters(path, options, print, "typeParameters")
       ]);
     case "TSLiteralType":
       return path.call(print, "literal");

diff --git a/tests/typescript_import_type/__snapshots__/jsfmt.spec.js.snap b/tests/typescript_import_type/__snapshots__/jsfmt.spec.js.snap
@@ -10,6 +10,10 @@ export let y: import("./foo2").Bar.I = { a: "", b: 0 };
 export let shim: typeof import("./foo2") = {
     Bar: Bar2
 };
+
+export interface Foo {
+    bar: import('immutable').Map<string, int>;
+}
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 // ref: https://github.com/Microsoft/TypeScript/pull/22592
 
@@ -21,6 +25,10 @@ export let shim: typeof import("./foo2") = {
   Bar: Bar2
 };
 
+export interface Foo {
+  bar: import("immutable").Map<string, int>;
+}
+
 `;
 
 exports[`import-type.ts 2`] = `
@@ -33,6 +41,10 @@ export let y: import("./foo2").Bar.I = { a: "", b: 0 };
 export let shim: typeof import("./foo2") = {
     Bar: Bar2
 };
+
+export interface Foo {
+    bar: import('immutable').Map<string, int>;
+}
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 // ref: https://github.com/Microsoft/TypeScript/pull/22592
 
@@ -44,4 +56,8 @@ export let shim: typeof import('./foo2') = {
   Bar: Bar2
 };
 
+export interface Foo {
+  bar: import('immutable').Map<string, int>;
+}
+
 `;
diff --git a/tests/typescript_import_type/import-type.ts b/tests/typescript_import_type/import-type.ts
@@ -7,3 +7,7 @@ export let y: import("./foo2").Bar.I = { a: "", b: 0 };
 export let shim: typeof import("./foo2") = {
     Bar: Bar2
 };
+
+export interface Foo {
+    bar: import('immutable').Map<string, int>;
+}