Fix angular unstable expression binding (#7924)

prettier · Apr 2, 2020 · bcf99ad · bcf99ad
1 parent 93aa378
commit bcf99ad
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js
@@ -3629,7 +3629,7 @@ function printPathNoParens(path, options, print, args) {
     case "NGEmptyExpression":
       return "";
     case "NGQuotedExpression":
-      return concat([n.prefix, ":", n.value]);
+      return concat([n.prefix, ": ", n.value.trim()]);
     case "NGMicrosyntax":
       return concat(
         path.map(

diff --git a/tests/html_angular/__snapshots__/jsfmt.spec.js.snap b/tests/html_angular/__snapshots__/jsfmt.spec.js.snap
@@ -464,7 +464,7 @@ trailingComma: "none"
   [target]="a"
   [target]="a // hello"
   [target]="a.b"
-  [target]="javascript: 'hello world' "
+  [target]="javascript: 'hello world'"
   [target]="a?.b()"
   [target]="a?.b"
   [target]="this.a"
@@ -734,7 +734,7 @@ printWidth: 80
   [target]="a"
   [target]="a // hello"
   [target]="a.b"
-  [target]="javascript: 'hello world' "
+  [target]="javascript: 'hello world'"
   [target]="a?.b()"
   [target]="a?.b"
   [target]="this.a"
@@ -1604,7 +1604,7 @@ printWidth: 80
   [target]="a"
   [target]="a // hello"
   [target]="a.b"
-  [target]="javascript: 'hello world' "
+  [target]="javascript: 'hello world'"
   [target]="a?.b()"
   [target]="a?.b"
   [target]="this.a"
@@ -1875,7 +1875,7 @@ printWidth: 80
   [target]="a"
   [target]="a // hello"
   [target]="a.b"
-  [target]="javascript: 'hello world' "
+  [target]="javascript: 'hello world'"
   [target]="a?.b()"
   [target]="a?.b"
   [target]="this.a"

diff --git a/tests_config/run_spec.js b/tests_config/run_spec.js
@@ -29,10 +29,6 @@ const unstableTests = new Map(
     "comments/tagged-template-literal.js",
     "comments_closure_typecast/iife.js",
     "graphql_interface/separator-detection.graphql",
-    [
-      "html_angular/attributes.component.html",
-      (options) => options.printWidth === 1,
-    ],
     "markdown_footnoteDefinition/multiline.md",
     "markdown_spec/example-234.md",
     "markdown_spec/example-235.md",