fix(javascript): add missing parens for binary in optionalMember (#5543)

prettier · Nov 25, 2018 · c788842 · c788842
1 parent ab7f46b
commit c788842
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/src/language-js/needs-parens.js b/src/language-js/needs-parens.js
@@ -258,6 +258,7 @@ function needsParens(path, options) {
           return true;
 
         case "MemberExpression":
+        case "OptionalMemberExpression":
           return name === "object" && parent.object === node;
 
         case "AssignmentExpression":

diff --git a/tests/optional_chaining/__snapshots__/jsfmt.spec.js.snap b/tests/optional_chaining/__snapshots__/jsfmt.spec.js.snap
@@ -23,6 +23,9 @@ a?.b[3].c?.(x).d.e?.f[3].g?.(y).h;
 
 (a?.b)?.c.d?.e;
 (a ? b : c)?.d;
+
+(list || list2)?.length;
+(list || list2)?.[(list || list2)];
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 var street = user.address?.street;
 var fooValue = myForm.querySelector("input[name=foo]")?.value;
@@ -47,4 +50,7 @@ a?.b[3].c?.(x).d.e?.f[3].g?.(y).h;
 a?.b?.c.d?.e;
 (a ? b : c)?.d;
 
+(list || list2)?.length;
+(list || list2)?.[list || list2];
+
 `;
diff --git a/tests/optional_chaining/chaining.js b/tests/optional_chaining/chaining.js
@@ -20,3 +20,6 @@ a?.b[3].c?.(x).d.e?.f[3].g?.(y).h;
 
 (a?.b)?.c.d?.e;
 (a ? b : c)?.d;
+
+(list || list2)?.length;
+(list || list2)?.[(list || list2)];