Generic arguments are lost when using import types

[aengl]

Prettier 1.13.4
Playground link

--parser typescript

Input:

declare interface Foo {
  bar: import('immutable').Map<string, int>;
}

Output:

declare interface Foo {
  bar: import("immutable").Map;
}

Expected behavior:
Generic arguments <string, int> should not be stripped.

If this turns out to be complicated, I'd be happy to contribute code myself. Let me know! 😃

[ikatyang]

I guess you meant you'd like to contribute if it's not complicated, you just need to print the missing typeParameters here:

prettier/src/language-js/printer-estree.js

Lines 2935 to 2942 in 35a42be

	case "TSLastTypeNode": // TSImportType
	return concat([
	!n.isTypeOf ? "" : "typeof ",
	"import(",
	path.call(print, "argument"),
	")",
	!n.qualifier ? "" : concat([".", path.call(print, "qualifier")])
	]);

and add a test case in tests/typescript_import_type/import-type.ts then yarn test -u.

See also https://github.com/prettier/prettier/blob/master/CONTRIBUTING.md.

[aengl]

Happy to help in either case, actually. Thanks for the pointers, I'll work on a PR this weekend.

[aengl]

PR: #4662