Composed functions not put on own line anymore after 1.14.0 update

[felixfbecker]

Getting these diffs a lot after the 1.14 update. Seems like the functional composition detection doesn't work anymore

         this.subscriptions.add(
             this.componentUpdates
-                .pipe(
-                    startWith(this.props),
-                    distinctUntilChanged(isEqual)
-                )
+                .pipe(startWith(this.props), distinctUntilChanged(isEqual))
                 .subscribe((props: Props) => {
                     const newParentPath = props.activePathIsDir ? props.activePath : dirname(props.activePath)
                     const queryParams = new URLSearchParams(this.props.history.location.search)

Prettier 1.14.0
Playground link

Input:

this.subscriptions.add(
            this.componentUpdates
                .pipe(startWith(this.props), distinctUntilChanged(isEqual))
                .subscribe(props => {
                    
                })
        )

Output:

this.subscriptions.add(
  this.componentUpdates
    .pipe(startWith(this.props), distinctUntilChanged(isEqual))
    .subscribe(props => {})
);

Expected behavior:

this.subscriptions.add(
  this.componentUpdates
    .pipe(
      startWith(this.props),
      distinctUntilChanged(isEqual)
     )
    .subscribe(props => {})
);

as it was with 1.13

[suchipi]

We recently blacklisted anything with this in it to try to cut down some of the false positives, but I didn't think about this use-case. We'll have to revert it.

[ikatyang]

I'd like to release 1.14.1 (ref: #4916 (comment) and #4932 (comment)), do you plan to fix this one in 1.14.1?

[suchipi]

@ikatyang made a PR, it can go in 1.14.1

[felixfbecker]

This is still happening in 1.14.2:

diff --git a/web/src/search/input/SearchFilterChips.tsx b/web/src/search/input/SearchFilterChips.tsx
index fabd6119b7..5acfd50d53 100644
--- a/web/src/search/input/SearchFilterChips.tsx
+++ b/web/src/search/input/SearchFilterChips.tsx
@@ -96,9 +96,7 @@ export class SearchFilterChips extends React.PureComponent<Props, State> {
         return (
             <div className="search-filter-chips">
                 {/* Filtering out empty strings because old configurations have "All repositories" with empty value, which is useless with new chips design. */}
-                {scopes
-                    .filter(scope => scope.value !== '')
-                    .map((scope, i) => (
+                {scopes.filter(scope => scope.value !== '').map((scope, i) => (
                     <FilterChip
                         query={this.props.query}
                         onFilterChosen={this.onSearchScopeClicked}

[ikatyang]

It does not look related to this issue, we only special-cased these functions:

prettier/src/language-js/printer-estree.js

Lines 3429 to 3440 in 9120689

	const functionCompositionFunctionNames = new Set([
	"pipe", // RxJS, Ramda
	"pipeP", // Ramda
	"pipeK", // Ramda
	"compose", // Ramda, Redux
	"composeFlipped", // Not from any library, but common in Haskell, so supported
	"composeP", // Ramda
	"composeK", // Ramda
	"flow", // Lodash
	"flowRight", // Lodash
	"connect" // Redux
	]);

Could you open a new issue?

[felixfbecker]

#5042