Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸŽ‰πŸŽ‰ πŸ’―βœ–πŸ’―βž•1️⃣ πŸŽ‰πŸŽ‰ #10001

Closed
wants to merge 1 commit into from

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Jan 4, 2021

πŸŽ‰πŸŽ‰ πŸ’―βœ–πŸ’―βž•1️⃣ πŸŽ‰πŸŽ‰

@fisker fisker changed the title #10001 πŸŽ‰πŸŽ‰ πŸ”Ÿβœ–πŸ’―βž•1️⃣ πŸŽ‰πŸŽ‰ Jan 5, 2021
@fisker fisker force-pushed the 10001 branch 4 times, most recently from 04b951e to baa591e Compare January 5, 2021 02:23
@fisker fisker marked this pull request as ready for review January 5, 2021 02:30
@fisker fisker changed the title πŸŽ‰πŸŽ‰ πŸ”Ÿβœ–πŸ’―βž•1️⃣ πŸŽ‰πŸŽ‰ πŸŽ‰πŸŽ‰ πŸ’―βœ–πŸ’―βž•1️⃣ πŸŽ‰πŸŽ‰ Jan 5, 2021
Comment on lines +3 to +8
// Advanced math expression evaluate algorithm invented by @prettier in 2021
// Steps:
// 1. Convert math expression to `boolean`
// 2. Convert `boolean` result back to `number`
// 3. Get the result of the math expression
const evaluate = (expression) => Number(Boolean(expression));
Copy link
Sponsor Member Author

@fisker fisker Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want add test for this, because I'm πŸ’― sure there is no bug.

fisker added a commit to fisker/prettier that referenced this pull request Jan 23, 2021
Base automatically changed from master to main January 23, 2021 17:13
@fisker
Copy link
Sponsor Member Author

fisker commented Aug 25, 2021

Abandon

@fisker fisker closed this Aug 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant