Throw errors for invalid left-hand side assignment #10416
Conversation
|
This is valid TypeScript. Looks like a bug in Babel. Prettier pr-10416 --parser babel-tsInput: (a as b) = c;Output: SyntaxError: Invalid parenthesized assignment pattern (1:1)
> 1 | (a as b) = c;
| ^ |
| 4 | | ||
| > 5 | (this.configuration as any) = (this.editor as any) = (this | ||
| | ^ | ||
| 6 | .editorBody as any) = undefined; |
There was a problem hiding this comment.
Weird. Babel supports this since long ago: babel/babel#7098
Why do we get an error?
There was a problem hiding this comment.
Turns out this is because of createParenthesizedExpressions: true.
There was a problem hiding this comment.
Disabling createParenthesizedExpressions for babel-ts is a solution.
# Conflicts: # src/language-js/parser-babel.js
|
Oops. This shouldn't parse: Prettier pr-10416 --parser babel-tsInput: a as any = x;Output: (a as any) = x; |
|
This should parse, but Prettier breaks it (AST isn't aligned with typescript-estree): Prettier pr-10416 --parser babel-tsInput: [a as any] = x;Output: [a: any] = x; |
|
Shouldn't parse. Prettier pr-10416 --parser babel-tsInput: ({a: b as any = 2} = x);Output: ({ a: b as any = 2 } = x); |
There was a problem hiding this comment.
The things I found are all separate issues in Babel or Prettier. This PR is good.
I opened babel/babel#13070 and #10635.
Description
Fixes #10412
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨