Remove hacks for single-element unions/intersections #10457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn0
changed the title
thorn0
changed the title
fisker
reviewed
Mar 3, 2021
| @@ -980,7 +964,6 @@ module.exports = { | |||
| handleEndOfLineComment, | |||
| handleRemainingComment, | |||
| isTypeCastComment, | |||
| getGapRegex, | |||
There was a problem hiding this comment.
I believe this only used in js, should we remove it from comment attach?
There was a problem hiding this comment.
I'd rather keep it. It's a reasonable extension point. The default regex (/^[\s(]*$/) is JS-specific. It might work well for languages that use parens in a way similar to how JS uses them, but it's also possible that other languages might need to override this.
fisker
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to babel/babel#12758 now we can remove tricky workarounds for single-element unions and intersections.
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨