Properly format Sass module configuration values #11516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksy
force-pushed
the
sass-with-print-width
branch
from
5b41166
to
23d4faa
Compare
4 tasks
| $black: #222, | ||
| $border-radius: 0.1rem, | ||
| $font-family: | ||
| "Helvetica, sans-serif", |
There was a problem hiding this comment.
hm , I think it should on the same line...
There was a problem hiding this comment.
It’s whole string so it’s placed in new line when line width is 40 characters or less. Try playing with print width.
lipis
approved these changes
Nov 24, 2021
fisker
approved these changes
Jul 19, 2022
|
@niksy Can you fix conflicts? |
niksy
force-pushed
the
sass-with-print-width
branch
from
3cee521
to
c44be1a
Compare
|
@fisker done! |
|
@alexander-akait Are you fine with this change? |
niksy
force-pushed
the
sass-with-print-width
branch
from
c44be1a
to
c602c02
Compare
niksy
force-pushed
the
sass-with-print-width
branch
from
c602c02
to
6e7530c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mentioned in #11487 (comment).
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨