Bundle Pure ESM Packages into /vendors/*.js as CommonJS
#12217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
force-pushed
the
esm-vendors
branch
from
9c8c496
to
4717a74
Compare
|
Can we do this in |
fisker
reviewed
Feb 3, 2022
My 2 cents, I personally don't like putting stuff in |
sosukesuzuki
force-pushed
the
esm-vendors
branch
2 times, most recently
from
460084c
to
5a86d5f
Compare
|
We don't have many opportunities to run this script, so I don't think it's worth running it in |
fisker
reviewed
Feb 4, 2022
|
|
||
| const changelogUnreleasedDir = fileURLToPath( | ||
| new URL("../changelog_unreleased", import.meta.url) | ||
| ); | ||
|
|
||
| const files = globby.sync(["blog-post-intro.md", "*/*.md"], { | ||
| const files = globbySync(["blog-post-intro.md", "*/*.md"], { |
There was a problem hiding this comment.
Actually this file is the reason I propose sindresorhus/globby#176
sosukesuzuki
force-pushed
the
esm-vendors
branch
from
71fb2ba
to
3972a28
Compare
fisker
approved these changes
Feb 5, 2022
This reverts commit 5a86d5f.
sosukesuzuki
force-pushed
the
esm-vendors
branch
from
3972a28
to
a2acdd5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bundles external Pure ESM Packages to CJS (#12209 (comment)).
See https://github.com/prettier/prettier/blob/b62b8e6d414d10b7cb37c343012a3a89a38aad8a/scripts/vendors/README.md for architecture.
In this PR, bundles following 3 packages:
string-widthglobbyglobbyis replaced withfast-globin our source code)memChecklist
✨Try the playground for this PR✨