New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support decorator auto accessors syntax #12299
Merged
sosukesuzuki
merged 9 commits into
prettier:main
from
sosukesuzuki:decorators-auto-accesor
Mar 2, 2022
Merged
Support decorator auto accessors syntax #12299
sosukesuzuki
merged 9 commits into
prettier:main
from
sosukesuzuki:decorators-auto-accesor
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duailibe
approved these changes
Feb 13, 2022
I haven't test yet, but have you checked this part https://github.com/sosukesuzuki/prettier/blob/9a07ac7ba097e5eaaf397a33f352bccbf0617009/src/language-js/print/statement.js#L174? |
fisker
reviewed
Feb 16, 2022
src/language-js/parse/babel.js
Outdated
@@ -38,6 +38,8 @@ const parseOptions = { | |||
"moduleBlocks", | |||
"asyncDoExpressions", | |||
"regexpUnicodeSets", | |||
// @ts-expect-error -- waiting https://github.com/babel/babel/pull/14266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sosukesuzuki
force-pushed
the
decorators-auto-accesor
branch
from
March 1, 2022 11:22
9a07ac7
to
d3dc1ea
Compare
fisker
approved these changes
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports auto accessors syntax from new decorator proposal.
Partial of #12255
Checklist
changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨