Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor to cosmiconfig search #13205

Merged
merged 2 commits into from Aug 3, 2022
Merged

Minor refactor to cosmiconfig search #13205

merged 2 commits into from Aug 3, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 2, 2022 •
edited

Description

  • Move loadToml, loadJson5 inline, it's just simple wrapper
  • Use async toml parser
  • import json5 parser directly, reduce bundle size

Looks like cosmiconfig is handing to stylelint

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker merged commit d4a49e2 into prettier:next Aug 3, 2022
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 17, 2024
@fisker @medikoo
Minor refactor to cosmiconfig search (prettier#13205)
8f8ca5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sosukesuzuki