Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing commas from function arguments in maps #14089

Merged
merged 15 commits into from Jan 6, 2023
Merged

Fix removing commas from function arguments in maps #14089

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c3c476
Fix in printer-side
sosukesuzuki Dec 30, 2022
bc3694f
Add tests
sosukesuzuki Dec 30, 2022
f9b4f64
Fix tests
sosukesuzuki Dec 30, 2022
fbd0ed2
Add changelog
sosukesuzuki Dec 30, 2022
8974873
Add comments
sosukesuzuki Dec 30, 2022
79c308c
Add comment
sosukesuzuki Dec 31, 2022
a0b061a
Address review
sosukesuzuki Jan 3, 2023
db6864a
Merge branch 'main' into fix-13984-2
sosukesuzuki Jan 3, 2023
0e044da
Merge branch 'main' into fix-13984-2
sosukesuzuki Jan 3, 2023
29842ce
Fix SCSSInterpolation detection
fisker Jan 3, 2023
2d213d1
Improve logic
fisker Jan 3, 2023
ae13eca
More tests
fisker Jan 3, 2023
7de4afa
Fix cases with multiple strings
fisker Jan 3, 2023
ef7d735
Merge branch 'main' into fix-13984-2
sosukesuzuki Jan 6, 2023
ee114cb
Revert change of `isSCSSMapItemNode`
sosukesuzuki Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/language-css/printer-postcss.js
View file
Open in desktop
Expand Up @@ -857,6 +857,13 @@ function genericPrint(path, options, print) {
}

if (isMapItemNode) {
// Nodes after the colon are considered to be the value part of a key-value pair
// $foo: map-fn(
// (
// "foo" : "bar #{inner-fn($baz)}"
// ^^^^^(node.groups[0]) ^(node.groups[1]) ^^^^^^^^^^^^^^^^^^^^^^^(isPartOfValue === true)
// )
// );
const isPartOfValue =
fisker marked this conversation as resolved.
Show resolved Hide resolved
node.groups?.[1]?.type === "value-colon" && i > 1;
if (
fisker marked this conversation as resolved.
Show resolved Hide resolved
Expand Down