Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cursor tracking #14812

Merged
merged 6 commits into from Jul 6, 2023
Merged

Improve cursor tracking #14812

merged 6 commits into from Jul 6, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented May 10, 2023

Description

Attempt to fix #14811, didn't run test locally, not sure about the result.

Fixes #14811

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the title [TEST]Improve cursor tracking Improve cursor tracking May 10, 2023
@fisker
Copy link
Member Author

fisker commented May 10, 2023

Though there are unsolved questions left in #14811, this can still merge since leading comments doesn't belong to node.

@fisker fisker marked this pull request as ready for review May 10, 2023 11:55
@fisker fisker merged commit e2f4ce3 into prettier:main Jul 6, 2023
27 checks passed
@fisker fisker deleted the cursor-comment branch July 6, 2023 01:51
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong cursorOffset with multi-line comment
1 participant