Fix comments print in IfStatement
#15076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Jul 11, 2023
|
|
||
| // TODO[@fisker]: fix this | ||
| // if (a) var a = 1; /* comment 6e */ | ||
| // else return 2; |
There was a problem hiding this comment.
markerForIfWithoutBlockAndSameLineComment was introduced in #12017, do you remember why we attach the comment as dangling instead of trailing comment?
Many nodes can be a child of IfStatement, though this code is not reasonable, but still valid, the comment is not printed.
There was a problem hiding this comment.
I forget... but I tried to run tests in local with:
- addDanglingComment(
- precedingNode,
- comment,
- markerForIfWithoutBlockAndSameLineComment,
- );
+ addTrailingComment(precedingNode, comment);then I got the spanpshot diffs like this:
- if (a === 0) expr; // comment A3
- else if (a === 1) expr; // comment B3
+ if (a === 0)
+ expr; // comment A3
+ else if (a === 1)
+ expr; // comment B3At the time, I may have wanted to avoid this line break.
kachkaev
reviewed
Jul 11, 2023
| @@ -93,26 +93,44 @@ parsers: ["babel", "flow", "typescript"] | |||
| printWidth: 80 | |||
| | printWidth | |||
| =====================================input====================================== | |||
| if (a === 0) doSomething(); // comment A1 | |||
| if (a === 0) doSomething(); // comment A1 | |||
There was a problem hiding this comment.
Where does this extra spacing come from? Not sure if i is expected in output, but maybe I am missing something.
There was a problem hiding this comment.
I added to align IfStatement.conquest.
sosukesuzuki
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15007
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨