New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing to support readonly
array properties of AST Node
#15127
Conversation
/** After */ | ||
// Now works fine too | ||
path.map(() => "", "readonlyArray"); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use Prettier stable
and Prettier main
instead of before/after
. https://github.com/prettier/prettier/blob/main/changelog_unreleased/TEMPLATE.md
Is it possible to test here? https://github.com/prettier/prettier/tree/main/tests/dts |
prettier/tests/dts/unit/cases/plugins.ts Lines 4 to 7 in 24dfe5a
|
As I tested, if I remove added $ yarn jest tests/dts
DeprecationWarning: 'originalKeywordKind' has been deprecated since v5.0.0 and will no longer be usable after v5.2.0. Use 'identifierToKeywordKind(identifier)' instead.
FAIL tests/dts/unit/run.js
● Test suite failed to run
Error [ERR_WORKER_OUT_OF_MEMORY]: Worker terminated due to reaching memory limit: JS heap out of memory
Test Suites: 1 failed, 1 total
Tests: 0 total
Snapshots: 0 total
Time: 94.418 s
Ran all test suites matching /tests\/dts/i. |
This seems related: #15034 (comment) Very weird... |
…er#15127) * Add typing to support `readonly` array properties of AST Node * add changelog * fix changelog * add test case
Description
Closes: #15034
TS Playground
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨