Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Node.js v20 version #15373

Merged
merged 3 commits into from Sep 12, 2023
Merged

Unpin Node.js v20 version #15373

merged 3 commits into from Sep 12, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Sep 9, 2023

Description

nodejs/node#49497 has been fixed and released.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

nodejs/node#49497 has been fixed and released.
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Size Change: 0 B

Total Size: 8.38 MB

ℹ️ View Unchanged
Filename Size
./dist/bin 4.1 kB
./dist/bin/prettier.cjs 2.15 kB
./dist/doc.d.ts 6.91 kB
./dist/doc.js 51 kB
./dist/doc.mjs 47.3 kB
./dist/index.cjs 33.5 kB
./dist/index.d.ts 26.5 kB
./dist/index.mjs 812 kB
./dist/internal 4.1 kB
./dist/internal/cli.mjs 230 kB
./dist/internal/internal.mjs 19.8 kB
./dist/LICENSE 239 kB
./dist/package.json 6.21 kB
./dist/plugins 4.1 kB
./dist/plugins/acorn.d.ts 109 B
./dist/plugins/acorn.js 149 kB
./dist/plugins/acorn.mjs 148 kB
./dist/plugins/angular.d.ts 177 B
./dist/plugins/angular.js 42.8 kB
./dist/plugins/angular.mjs 42.1 kB
./dist/plugins/babel.d.ts 402 B
./dist/plugins/babel.js 311 kB
./dist/plugins/babel.mjs 310 kB
./dist/plugins/estree.d.ts 11 B
./dist/plugins/estree.js 185 kB
./dist/plugins/estree.mjs 185 kB
./dist/plugins/flow.d.ts 90 B
./dist/plugins/flow.js 680 kB
./dist/plugins/flow.mjs 680 kB
./dist/plugins/glimmer.d.ts 93 B
./dist/plugins/glimmer.js 133 kB
./dist/plugins/glimmer.mjs 132 kB
./dist/plugins/graphql.d.ts 93 B
./dist/plugins/graphql.js 43.7 kB
./dist/plugins/graphql.mjs 43 kB
./dist/plugins/html.d.ts 139 B
./dist/plugins/html.js 138 kB
./dist/plugins/html.mjs 138 kB
./dist/plugins/markdown.d.ts 127 B
./dist/plugins/markdown.js 148 kB
./dist/plugins/markdown.mjs 148 kB
./dist/plugins/meriyah.d.ts 93 B
./dist/plugins/meriyah.js 120 kB
./dist/plugins/meriyah.mjs 120 kB
./dist/plugins/postcss.d.ts 121 B
./dist/plugins/postcss.js 153 kB
./dist/plugins/postcss.mjs 153 kB
./dist/plugins/typescript.d.ts 96 B
./dist/plugins/typescript.js 1.15 MB
./dist/plugins/typescript.mjs 1.15 MB
./dist/plugins/yaml.d.ts 90 B
./dist/plugins/yaml.js 122 kB
./dist/plugins/yaml.mjs 121 kB
./dist/README.md 4.03 kB
./dist/standalone.d.ts 1.42 kB
./dist/standalone.js 74.3 kB
./dist/standalone.mjs 74.1 kB

compressed-size-action

Copy link
Member

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe GitHub is still using an older version of Node 20 by default, which causes CI failing. We can re-run failed jobs a few times and merge this PR when they become green. Diff-wise, all good!

@fisker
Copy link
Member Author

fisker commented Sep 9, 2023

@fisker
Copy link
Member Author

fisker commented Sep 9, 2023

Guess we need wait for this file to get upgraded. https://github.com/actions/node-versions/blob/015a819882d6df938971abeda2a04ef53111c072/versions-manifest.json#L3

@fisker fisker merged commit 909e0e6 into main Sep 12, 2023
28 of 29 checks passed
@fisker fisker deleted the node-20-6-1 branch September 12, 2023 01:57
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants