Fix formatting error on member chain #15915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this is caused by #15806 |
sosukesuzuki
commented
Jan 12, 2024
src/language-js/utils/index.js
Outdated
Comment on lines
408
to
417
| // @ts-expect-error | ||
| if (node.object == null) { | ||
| // @ts-expect-error | ||
| node.object = node.expression.object; | ||
| } | ||
| // @ts-expect-error | ||
| if (node.property == null) { | ||
| // @ts-expect-error | ||
| node.property = node.expression.property; | ||
| } |
There was a problem hiding this comment.
@fisker This isn't a good. I'm merging this PR as a temporary solution, but do you have any better solution?
There was a problem hiding this comment.
Yes, this is wrong, should update logic where it's accessing the object/property.
There was a problem hiding this comment.
This may also cause computed/shorthand check part result wrong..
1 task
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15912
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨