.eslintrc.js: Use trailingComma: "es5" with Prettier
#3492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses prettier#3469 as outlined in prettier#3469 (comment) The corresponding formatting changes will be done separately for clarity's sake.
azz
requested changes
Dec 14, 2017
.eslintrc.js
Outdated
| @@ -22,15 +22,15 @@ module.exports = { | |||
| "one-var": ["error", "never"], | |||
| "prefer-arrow-callback": "error", | |||
| "prefer-const": "error", | |||
| "prettier/prettier": "error", | |||
| "prettier/prettier": ["error", { trailingComma: "es5" }], | |||
There was a problem hiding this comment.
Please don't put the setting here, it breaks Prettier editor integrations that rely on Prettier's config file.
There was a problem hiding this comment.
Ah, I didn't consider that. I had originally used .prettierrc, but the version of eslint-plugin-prettier we had didn't take it into account, so I had to upgrade that first. Fixed in ed0b21f.
This gives us `.prettierrc` support.
This reverts commit 0b22329. This addresses the following: * prettier#3492 (comment) * prettier#3469 (comment)
|
Let's discuss changing the default value in #3503 |
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #3469
as outlined in #3469 (comment)
There are two commits at the moment, the first is the interesting change to
.eslintrc.js, and the second is the resulting formatting changes.