Print ObjectTypeInternalSlot with both flow/babel parsers #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
status:wip
suchipi
approved these changes
Jul 21, 2018
j-f1
reviewed
Jul 21, 2018
| return concat([ | ||
| n.static ? "static " : "", | ||
| "[[", | ||
| path.call(print, "id"), |
There was a problem hiding this comment.
What happens if the identifier goes past the printWidth?
|
Opened facebook/flow#6652 to ask for the |
|
@ikatyang |
existentialism
removed
the
status:wip
ikatyang
approved these changes
Aug 7, 2018
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4903
Now that facebook/flow#6320 has landed, we can add support for
ObjectTypeInternalSlot!WIP while waiting for
flow-parser@0.77to hit npm (it's tagged).Ref:
facebook/flow@732eae5
babel/babel#7947
babel/babel#7959