Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade to cosmiconfig@5 #4899

Merged
merged 2 commits into from Jul 29, 2018
Merged

refactor: upgrade to cosmiconfig@5 #4899

merged 2 commits into from Jul 29, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang
Copy link
Member Author

It seems cosmiconfig@5 uses require to resolve js config, which caused Error: Dynamic requires are not currently supported by rollup-plugin-commonjs.

@ikatyang ikatyang merged commit 440ab4f into prettier:master Jul 29, 2018
@ikatyang ikatyang deleted the refactor/cosmiconfig-v5 branch July 29, 2018 08:57
@ikatyang ikatyang added this to the 1.14.1 milestone Aug 2, 2018
This was referenced Aug 7, 2018
Closed
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Oct 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@duailibe duailibe duailibe approved these changes

@jorgegonzalez jorgegonzalez jorgegonzalez approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikatyang @duailibe @jorgegonzalez