Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update flow support info #4943

Merged
merged 2 commits into from Aug 8, 2018
Merged

fix: update flow support info #4943

merged 2 commits into from Aug 8, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Aug 7, 2018

Fixes #4942

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 7, 2018
@j-f1
Copy link
Member

j-f1 commented Aug 7, 2018

Are there Flow versions of the JS-specific keys that are now added?

@ikatyang
Copy link
Member Author

ikatyang commented Aug 7, 2018

I'm not sure what did you mean but the JavaScript in Linguist is actually js + flow, they didn't distinguish them. The reason why I originally added Flow is that I'd like to distinguish them, at least .js.flow is 100% Flow file.

@ikatyang ikatyang merged commit e72cb53 into prettier:master Aug 8, 2018
@ikatyang ikatyang deleted the fix/flow/support-info branch August 8, 2018 15:47
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suchipi suchipi suchipi approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikatyang @j-f1 @suchipi