Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): stable parens for function type in arrow return type #5790

Conversation

ikatyang
Copy link
Member

Fixes #5789

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.16.1 milestone Jan 22, 2019
Copy link

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested
const foo = (): (() => void) => (): void => null;
const bar = (): () => void => (): void => null;
const baz = (): ((() => void)) => (): void => null;

And
class Foo {
foo: (() => void)
}

In the playground, and it works well

@ikatyang ikatyang merged commit 153d2d0 into prettier:master Jan 22, 2019
@ikatyang ikatyang deleted the fix/typescript/parens-for-function-type-in-arrow-return-type branch January 22, 2019 13:07
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with type annotation, keep removing and adding parentheses
3 participants