Don’t remove generics in object methods in TS #5824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Feb 2, 2019
JamesHenry
previously approved these changes
Feb 2, 2019
existentialism
approved these changes
Feb 2, 2019
ikatyang
reviewed
Feb 2, 2019
| @@ -84,3 +84,29 @@ Examples: | |||
| // Output (Prettier master) | |||
| <my-element data-for={value}></my-element> | |||
| ``` | |||
|
|
|||
| - TypeScript: Don’t remove generics in object methods in TS ([#5824] by [@j-f1]) | |||
JamesHenry
dismissed
their stale review
@armano2 pointed out other issues and we have an AST update
JamesHenry
requested changes
Feb 4, 2019
There was a problem hiding this comment.
We should try with the latest canary release, we have fixed the AST regressions, and add missing coverage pointed out by @armano2
The release is 1.2.1-alpha.11
|
@j-f1 I tried to save you some time and make the changes, but I don't have permission to push to your fork Here are the changes: https://github.com/prettier/prettier/compare/pr/j-f1/5824-patches?expand=1 As you can see, it is basically just bump typescript-estree, revert all your other changes, add extra coverage. The tests all pass locally for me with |
|
1.3.0 of @typescript-eslint/typescript-estree got released |
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Mar 19, 2019
taken from the following PR: prettier#5824 Note that this test is not expected to succeed with outdated @typescript-eslint/typescript-estree dependendcy. Co-authored-by: Jed Fox <git@twopointzero.us> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Mar 19, 2019
as proposed in the following PR: prettier#5824 Note that this test is not expected to succeed without code changes when using an outdated version of the following dependency: @typescript-eslint/typescript-estree Co-authored-by: Jed Fox <git@twopointzero.us> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Mar 19, 2019
resolves the issue with generics in object methods in TypeScript and passes the test proposed in the following PR: prettier#5824 resolves prettier#5817
3 tasks
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Apr 4, 2019
as proposed in the following PR: prettier#5824 Note that this test is not expected to succeed without code changes when using an outdated version of the following dependency: @typescript-eslint/typescript-estree Co-authored-by: Jed Fox <git@twopointzero.us> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Apr 4, 2019
as proposed by @j-f1 in the following PR: prettier#5824 should validate that prettier#5817 does not reappear Co-authored-by: Jed Fox <git@twopointzero.us> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Apr 4, 2019
as proposed by @j-f1 in the following PR: prettier#5824 should validate that issue prettier#5817 does not reappear closes prettier#5817 as resolved and tested Co-authored-by: Jed Fox <git@twopointzero.us> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
brodybits
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Apr 4, 2019
as proposed by @j-f1 in the following PR: prettier#5824 should validate that issue prettier#5817 does not reappear this change closes prettier#5817 as resolved and tested this change closes prettier#5824 (PR prettier#5824) as superseded Co-authored-by: Jed Fox <git@twopointzero.us> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
|
I think this proposal should be closed as superseded by the following changes:
The change proposed in PR #5989 should close this one if it is merged. |
lock
bot
added
the
locked-due-to-inactivity
|
I'm going to delete the branch for this PR, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5817.
CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨