Update `globby` to v7.1.1 #6639

fisker · 2019-10-12T09:59:02Z

~~with globby v7.1.1, we support dot pattern and expandDirectories now.~~

~~fixes: #6085~~

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
(If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
I’ve read the contributing guidelines.

https://github.com/sindresorhus/globby/releases/tag/v7.0.0

alexander-akait · 2019-10-14T11:43:37Z

Added expandDirectories option which is on by default. The nodir option is now also true by default. This means that by default it will now only return file paths, not directory paths. cf55e5c

Looks like breaking changem try to use . pattern

lydell · 2019-10-14T15:27:27Z

Sounds like we need to add some tests, then.

src/cli/util.js

brodybits

see my questions & comment

scripts/run-external-tests.js

src/cli/util.js

src/common/load-plugins.js

?

src/cli/util.js

brodybits · 2019-10-27T20:10:40Z

I have a few more questions:

Any explanation for the small loss of code coverage?
Could this resolve support dot pattern for CLI #6085?
Should we consider using globby@10 if we do not support install from GitHub on Node.js 6?

fisker · 2019-10-28T01:06:26Z

I was trying to make tests the another day, then I got distracted by #6665 .

Those options are really confusing me, as I understand,

nodir means donot list dirname , since we are looking for file we should use default true

expandDirectories also means that?

brodybits · 2019-10-28T02:45:36Z

I think part of the confusion is how much globby has changed over quite a few major versions. I think we should try to research and understand this carefully before making any more adjustments. I do think we should also avoid using any options not really needed.

I am now really thinking we should consider using the latest rather than trying to deal with the old, unsupported package versions.

Unfortunately I don't have much time to look into this right now.

brodybits · 2019-10-29T21:50:17Z

I tried raising RFC PR #6748 to try globby@10 update for discussion, seems to be mostly working with a few TODO items. I think that nodir setting is not needed in some newer versions of globby, removing it does not cause any failures. I am also thinking that expandDirectories should not be an issue since Prettier only works with files. But I may prove to be mistaken here.

fisker · 2019-10-30T01:27:53Z

closing in favor of #6748

brodybits · 2019-10-30T01:42:54Z

closing in favor of #6748

Any ideas how we can resolve the TODO items in PR #6748?

# Conflicts: # package.json

fisker · 2019-11-01T01:50:17Z

@lydell @evilebottnawi @brodybits

I reopened this, and add dot pattern and expandDirectories tests.

This will not breaking anything, but support prettier . and prettier src, we can safely add this to v1.19

brodybits · 2019-11-01T02:15:53Z

tests_integration/__tests__/patterns.js

+
+expect.addSnapshotSerializer(require("../path-serializer"));
+
+// TODO: move `multiple-patterns` tests into this one


Can you explain why we would want to do this in the future?

I would only favor combining tests if they have the exact same output and can help reduce the number of snapshots we have to maintain.

Assuming there would be a good reason to do this, I would really favor adding this comment to tests_integration/__tests__/multiple-patterns.js as well to avoid losing track of this TODO item.

not all tests are multiple-patterns , name to patterns should be more reasonable

fisker · 2019-11-01T20:27:17Z

@lydell

If I understand currectly, what do you want is
prettier . --write
prettier dir/ --write
prettier . --list
prettier dir/ --list
not print UndefinedParserError

and
prettier **/* --write
prettier dir/**/* --write
prettier **/* --list
prettier dir/**/* --list

print UndefinedParserError (currently behavior)

is that currect?

lydell · 2019-11-01T20:46:35Z

Yes, that’s correct!

fisker · 2019-11-01T20:55:19Z

prettier dir1 dir2
prettier dir1 dir2/**/*
prettier non-exists-dir dir2/**/*
prettier . dir2/**/*

Can you explain to me, what those 4 should be?

lydell · 2019-11-01T21:03:03Z

prettier dir1 dir2 – prettify all files with supported extensions inside dir1 and dir2.
prettier dir1 dir2/**/* – prettify all files with supported extensions inside dir1 as well as all files matched by the dir2/**/* glob. If any of the latter files have unknown extensions – log an error for them.
prettier non-exists-dir dir2/**/* – log an error that non-exists-dir resulted in 0 files and prettify all files matched by the dir2/**/* glob. If any of the latter files have unknown extensions – log an error for them.
prettier . dir2/**/* – prettify all files with supported extensions in . and all files matched by the dir2/**/* glob. If any of the latter files have unknown extensions – log an error for them.

I basically want the same behavior as eslint.

fisker · 2019-11-01T21:17:22Z

just to clearify not supported extensions, because parser can be override by config.

lydell · 2019-11-01T21:23:47Z

For every file we go through, try to resolve the final config to use for that file like we already do. If parser is missing, throw an error if the file came from a full path or glob, and ignore the file if it came from a folder pattern. If a pattern (item in process.argv) results in 0 files (non-existent folder, empty folder, folder with no supported files, glob that does not match anything, non-existent file), warn about it resulting in 0 files.

brodybits · 2019-11-01T21:27:36Z

For every file we go through, try to resolve the final config to use for that file like we already do.
[...]

Shouldn't this already be covered by the test suite?

If not, I think we should add the missing tests.

fisker · 2019-11-01T21:32:06Z

I've disabled all the behavior changes, it's only package upgrade now.

alexander-akait · 2019-11-05T12:11:04Z

Also don't forget what plugins can add own extensions and it should be tested also (when we implement . support)

alexander-akait · 2019-11-05T12:11:55Z

src/cli/util.js

@@ -407,11 +407,13 @@ function eachFilename(context, patterns, callback) {
    patterns = patterns.concat(["!**/node_modules/**", "!./node_modules/**"]);
  }
  patterns = patterns.concat(["!**/.{git,svn,hg}/**", "!./.{git,svn,hg}/**"]);
+  patterns = patterns.filter(pattern => pattern !== ".");


Let's add comment here why we do this

alexander-akait · 2020-01-29T13:34:19Z

@fisker please fix conflicts and let's do it for next

@prettier/core please review

# Conflicts: # package.json # yarn.lock

…e-globby

fisker · 2020-01-29T14:55:42Z

Rebased & CI passed.

fisker · 2020-02-04T11:48:41Z

What are we going to do with this one?

alexander-akait · 2020-02-04T12:00:19Z

@fisker If we can't update globby to latest we need merge this branch

fisker · 2020-02-16T16:25:56Z

Closing in favor of #6776

fisker added 4 commits October 12, 2019 13:24

Update globby to v7.0.0

3d10690

Update globby to v7.1.1

561ef60

remove nodir

d1b93e8

https://github.com/sindresorhus/globby/releases/tag/v7.0.0

Merge branch 'master' into update-globby

6b70081

lydell previously approved these changes Oct 12, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

set expandDirectories -> false

abb63e2

lydell reviewed Oct 15, 2019

View reviewed changes

src/cli/util.js Outdated Show resolved Hide resolved

brodybits mentioned this pull request Oct 27, 2019

this PR need revert #6719

Closed

brodybits reviewed Oct 27, 2019

View reviewed changes

scripts/run-external-tests.js Outdated Show resolved Hide resolved

src/cli/util.js Outdated Show resolved Hide resolved

src/common/load-plugins.js Show resolved Hide resolved

brodybits reviewed Oct 27, 2019

View reviewed changes

src/cli/util.js Outdated Show resolved Hide resolved

brodybits mentioned this pull request Oct 29, 2019

[RFC DRAFT WIP] globby@10 update (with fast-glob implementation) #6748

Closed

5 tasks

fisker closed this Oct 30, 2019

fisker added 2 commits November 1, 2019 09:03

Merge branch 'master' into update-globby

b81857b

# Conflicts: # package.json

remove useless expandDirectories

30306db

fisker reopened this Nov 1, 2019

fisker added 2 commits November 1, 2019 09:19

add patterns tests

878803c

reuse multiple-patterns tests

f3838cd

fisker changed the title ~~Update globby to v7.1.1~~ Support dot pattern and expandDirectories with globby@7.1.1 Nov 1, 2019

brodybits reviewed Nov 1, 2019

View reviewed changes

disable behavior changes

929d7f7

fisker changed the title ~~Support dot pattern and expandDirectories with globby@7.1.1~~ Update globby to v7.1.1 Nov 1, 2019

alexander-akait reviewed Nov 5, 2019

View reviewed changes

Add comment

90f0ef9

alexander-akait approved these changes Nov 6, 2019

View reviewed changes

Merge branch 'master' into update-globby

b527c8f

fisker mentioned this pull request Jan 29, 2020

Update globby to v11 #6776

Merged

4 tasks

Merge branch 'next' into update-globby

0cf2cd7

# Conflicts: # package.json # yarn.lock

fisker changed the base branch from master to next January 29, 2020 13:54

Merge branch 'update-globby' of github.com:fisker/prettier into updat…

b35b1ba

…e-globby

fisker mentioned this pull request Feb 4, 2020

Add tests for globby update #7543

Merged

fisker mentioned this pull request Feb 14, 2020

Allow more arrow function print on same line with arrow #7541

Closed

4 tasks

thorn0 mentioned this pull request Feb 16, 2020

Check pattern existence before glob #7587

Merged

4 tasks

fisker closed this Feb 16, 2020

fisker deleted the update-globby branch April 21, 2020 07:47

github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `globby` to v7.1.1 #6639

Update `globby` to v7.1.1 #6639

fisker commented Oct 12, 2019 •

edited

alexander-akait commented Oct 14, 2019 •

edited

lydell commented Oct 14, 2019

This comment has been minimized.

brodybits left a comment

brodybits commented Oct 27, 2019

fisker commented Oct 28, 2019 •

edited

brodybits commented Oct 28, 2019

brodybits commented Oct 29, 2019

fisker commented Oct 30, 2019

brodybits commented Oct 30, 2019

fisker commented Nov 1, 2019 •

edited

brodybits Nov 1, 2019

fisker Nov 1, 2019

fisker commented Nov 1, 2019 •

edited

lydell commented Nov 1, 2019

fisker commented Nov 1, 2019

lydell commented Nov 1, 2019 •

edited

fisker commented Nov 1, 2019

lydell commented Nov 1, 2019

brodybits commented Nov 1, 2019

fisker commented Nov 1, 2019

alexander-akait commented Nov 5, 2019

alexander-akait Nov 5, 2019

fisker Nov 6, 2019

alexander-akait commented Jan 29, 2020

fisker commented Jan 29, 2020

fisker commented Feb 4, 2020 •

edited

alexander-akait commented Feb 4, 2020

fisker commented Feb 16, 2020


		expect.addSnapshotSerializer(require("../path-serializer"));

		// TODO: move `multiple-patterns` tests into this one

Update globby to v7.1.1 #6639

Update globby to v7.1.1 #6639

Conversation

fisker commented Oct 12, 2019 • edited

alexander-akait commented Oct 14, 2019 • edited

lydell commented Oct 14, 2019

This comment has been minimized.

brodybits left a comment

Choose a reason for hiding this comment

brodybits commented Oct 27, 2019

fisker commented Oct 28, 2019 • edited

brodybits commented Oct 28, 2019

brodybits commented Oct 29, 2019

fisker commented Oct 30, 2019

brodybits commented Oct 30, 2019

fisker commented Nov 1, 2019 • edited

brodybits Nov 1, 2019

Choose a reason for hiding this comment

fisker Nov 1, 2019

Choose a reason for hiding this comment

fisker commented Nov 1, 2019 • edited

lydell commented Nov 1, 2019

fisker commented Nov 1, 2019

lydell commented Nov 1, 2019 • edited

fisker commented Nov 1, 2019

lydell commented Nov 1, 2019

brodybits commented Nov 1, 2019

fisker commented Nov 1, 2019

alexander-akait commented Nov 5, 2019

alexander-akait Nov 5, 2019

Choose a reason for hiding this comment

fisker Nov 6, 2019

Choose a reason for hiding this comment

alexander-akait commented Jan 29, 2020

fisker commented Jan 29, 2020

fisker commented Feb 4, 2020 • edited

alexander-akait commented Feb 4, 2020

fisker commented Feb 16, 2020

Update `globby` to v7.1.1 #6639

Update `globby` to v7.1.1 #6639

fisker commented Oct 12, 2019 •

edited

alexander-akait commented Oct 14, 2019 •

edited

fisker commented Oct 28, 2019 •

edited

fisker commented Nov 1, 2019 •

edited

fisker commented Nov 1, 2019 •

edited

lydell commented Nov 1, 2019 •

edited

fisker commented Feb 4, 2020 •

edited