Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdin with async-to-promises #6895

Closed
wants to merge 1 commit into from
Closed

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Nov 9, 2019

Another solution for #6891, I'm Ok with any of them

#6894
#6893

also lacal tested

@lydell


file size

npm notice package: prettier@1.20.0-dev
npm notice === Tarball Contents ===
npm notice 468B    package.json
npm notice 1.4MB   bin-prettier.js
npm notice 70.6kB  doc.js
npm notice 1.3MB   index.js
npm notice 1.1kB   LICENSE
npm notice 57.4kB  parser-angular.js
npm notice 266.2kB parser-babylon.js
npm notice 1.5MB   parser-flow.js
npm notice 139.6kB parser-glimmer.js
npm notice 51.4kB  parser-graphql.js
npm notice 110.7kB parser-html.js
npm notice 241.1kB parser-markdown.js
npm notice 351.8kB parser-postcss.js
npm notice 2.6MB   parser-typescript.js
npm notice 167.7kB parser-yaml.js
npm notice 3.7kB   README.md
npm notice 1.1MB   standalone.js
npm notice 146.6kB third-party.js
npm notice === Tarball Details ===
npm notice name:          prettier
npm notice version:       1.20.0-dev
npm notice filename:      prettier-1.20.0-dev.tgz
npm notice package size:  2.2 MB
npm notice unpacked size: 9.6 MB
npm notice shasum:        2a9dfc544a44e3026a88d5ba326e378d5a480178
npm notice integrity:     sha512-MEeyf/9UATXuV[...]WXBKi+vKyL93A==
npm notice total files:   18
npm notice
prettier-1.20.0-dev.tgz
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@lydell
Copy link
Member

lydell commented Nov 9, 2019

As far as I understand, we won’t need this in 2.0 so I’m closing. Let me know if I’ve misunderstood anything.

Closing in favor of #6894.

@lydell lydell closed this Nov 9, 2019
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants