Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prettier-ignore in union types #7798

Merged
merged 5 commits into from Mar 22, 2020
Merged

fix prettier-ignore in union types #7798

merged 5 commits into from Mar 22, 2020

Conversation

thorn0
Copy link
Member

@thorn0 thorn0 commented Mar 20, 2020 •
edited

fixes #7797

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

alexander-akait
alexander-akait approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@thorn0 thorn0 changed the base branch from next to master March 21, 2020 21:04
@j-f1 j-f1 linked an issue Mar 21, 2020 that may be closed by this pull request
This code infinitely self-replicates every time Prettier formats it #7797
Closed
@thorn0 thorn0 merged commit 6835aa8 into prettier:master Mar 22, 2020
@thorn0 thorn0 deleted the prettier-ignore-in-unions branch March 22, 2020 23:30
@thorn0 thorn0 mentioned this pull request Jul 13, 2020
Open
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This code infinitely self-replicates every time Prettier formats it
3 participants
@thorn0 @alexander-akait @sosukesuzuki