Fix bug with holes in array literals #7911

bakkot · 2020-03-31T05:54:27Z

Fixes #7910, so that running Prettier against

new Test()
  .test()
  .test([, 0])
  .test();

no longer throws an error.

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

fisker · 2020-03-31T10:20:20Z

src/language-js/utils.js

@@ -958,7 +958,7 @@ function isSimpleCallArgument(node, depth) {
    );
  }
  if (node.type === "ArrayExpression") {
-    return node.elements.every(isChildSimple);
+    return node.elements.every((x) => x == null || isChildSimple(x));


Shouldn't this be === null ? holes always null

bakkot added 3 commits March 30, 2020 22:53

Fix bug with holes in array literals

b98f792

add changelog

995ce8a

rebuild snapshots

14d37b6

sosukesuzuki approved these changes Mar 31, 2020

View reviewed changes

thorn0 merged commit 18bf01e into master Mar 31, 2020

fisker reviewed Mar 31, 2020

View reviewed changes

alexander-akait deleted the holes-in-calls branch March 31, 2020 10:49

github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug with holes in array literals #7911

Fix bug with holes in array literals #7911

bakkot commented Mar 31, 2020 •

edited

fisker Mar 31, 2020

Fix bug with holes in array literals #7911

Fix bug with holes in array literals #7911

Conversation

bakkot commented Mar 31, 2020 • edited

fisker Mar 31, 2020

Choose a reason for hiding this comment

bakkot commented Mar 31, 2020 •

edited