Update isSCSS test regex
#7922
Merged
Update isSCSS test regex
#7922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Apr 1, 2020
src/language-css/utils.js
Outdated
| @@ -60,7 +60,7 @@ function getPropOfDeclNode(path) { | |||
|
|
|||
| function isSCSS(parser, text) { | |||
| const hasExplicitParserChoice = parser === "less" || parser === "scss"; | |||
| const IS_POSSIBLY_SCSS = /(\w\s*: [^}:]+|#){|@import[^\n]+(url|,)/; | |||
| const IS_POSSIBLY_SCSS = /(\w\s*: ?[^}:]+|#){|@import[^\n]+(url|,)/; | |||
There was a problem hiding this comment.
I can't understand regexp too 😄 , I think we should rewrite it, on looking extension
There was a problem hiding this comment.
You mean file extension? File extension is not always available, maybe check actual parser (not options.parser)?
This function is also used to decided parser...
thorn0
approved these changes
Apr 2, 2020
|
Let's keep it this way to make test pass, we won't need it anymore after #7933 |
alexander-akait
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
css_atrule/include.csssecond format.I don't really understand this regex, but space after
:should be optional.It's added in https://github.com/prettier/prettier/pull/4317/files#diff-29bcb0b461c4ae51930e975e53edfdd9L481
✨Try the playground for this PR✨